Score extension no longer features TMH player for generated <audio> elements
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	TheDJ
	Oct 20 2016, 10:27 AM

Description

Probably when we fixed TMH with proper module loading, we forgot about this dependency and no one has noticed (for like a year ???).

Details

	Subject	Repo	Branch	Lines +/-
	Regression fix for TMH + Score integration	mediawiki/extensions/Score	master	+8 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• brion	T148716 Score extension no longer features TMH player for generated <audio> elements
Open		None	T135501 Formalize how TMH provides a player for Score-generated ogg/vorbis files
Open	Feature	None	T60478 Improve interface for MediaHandlers to add JavaScript

Event Timeline

TheDJ created this task.Oct 20 2016, 10:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2016, 10:27 AM

TheDJ triaged this task as Low priority.Oct 20 2016, 10:28 AM

TheDJ added a subtask: T135501: Formalize how TMH provides a player for Score-generated ogg/vorbis files.

TheDJ added a project: Regression.

Jdforrester-WMF subscribed.Apr 27 2017, 3:31 PM

Ebe123 moved this task from Backlog to Audio on the MediaWiki-extensions-Score board.Dec 3 2017, 2:03 PM

The non-TMH player is nicer and just as functional in this case IMO.

Audio not in TimedMediaHandler's format cannot be played in the Safari browser (using Version 11.0.2 (13604.4.7.1.3)). Seems more serious as a bug now, and TMH should formalize how to instantiate players for other extensions.

Yeah, looks like it triggers if there's also a TMH file usage on the page, but not if there isn't. Will take a peek at this, though T181875 would also solve the Safari problem.

Change 402935 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/Score@master] Regression fix for TMH Score integration

https://gerrit.wikimedia.org/r/402935

gerritbot added a project: Patch-For-Review.Jan 8 2018, 9:20 PM

Change 402935 merged by jenkins-bot:
[mediawiki/extensions/Score@master] Regression fix for TMH Score integration

https://gerrit.wikimedia.org/r/402935

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 9 2018, 1:00 AM