: Invalid GeoJSON code in wgKartographerLiveData prevents drawing of maps at Wikivoyage
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RolandUnger
	Oct 24 2016, 2:40 PM

Description

If an article at Wikivoyage contains no markers (i.e. maplink codes with GeoJSON) an invalid GeoJSON code is created for the wgKartographerLiveData variable in the document header.

Working example (with text markers):
"wgKartographerLiveData":{"mask":[{"type":"Feature","geometry":{"coordinates":[[[36000,-180],[36000,180],...

Invalid GeoJSON, for instance at voy:en:Marshfield_(Massachusetts):
"wgKartographerLiveData":[[],[],[],[],[],[],[],[],[],[],[],[],[],[],...

The MediaWiki:Kartographer.js is not able to handle this code, and a JS error message like "Uncaught SyntaxError: Unexpected token u in JSON at position 0" occurs.

The effect of this faulty code is surely that the Kartographer map is not shown at all (empty space).

Details

	Subject	Repo	Branch	Lines +/-
	Fix missing live groups in Wikivoyage mode	mediawiki/extensions/Kartographer	master	+30 -23

Customize query in gerrit

Related Objects

Mentioned In: T149268: wikimedia-mapdata needs to be in a canonical location
T149231: Mapframe is displaying odd map

Event Timeline

RolandUnger created this task.Oct 24 2016, 2:40 PM

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptOct 24 2016, 2:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@RolandUnger thanks for reporting. We have done a number of data-related changes on the backend in the past two weeks, but it won't be deployed until Wednesday. Could you verify that this bug still exists at https://en.wikivoyage.beta.wmflabs.org/wiki/Mapframe ? I suspect we might have fixed it, but not sure.

@RolandUnger I tried to replicate that article with all of its templates at beta cluster, and it seems to be working ok. I will wait until Wednesday to re-visit this bug.

Today, all wgKartographerLiveData are wrong as shown below and, therefore, no map is shown.

"wgKartographerLiveData":[[],[],[],[],[],[],[],[],[],[],[],[],[],[],...

@RolandUnger the train runs at 19:00 UTC today, 12:00 PDT. That's when group1 sites (Wikivoyage) get the new update. See schedule at https://wikitech.wikimedia.org/wiki/Deployments

Lets revisit this after the train runs (assuming the deployment train is ok, and there are no overall deployment issues). Another good place to see the status is at https://tools.wmflabs.org/versions/ -- we are waiting for 1.28.0-wmf.23 in group 1

debt mentioned this in T149231: Mapframe is displaying odd map.Oct 26 2016, 6:47 PM

MaxSem moved this task from Needs triage to Maps on the Discovery-ARCHIVED board.Oct 26 2016, 9:23 PM

Still reproduceable.

The frontend error is gone, however Kartotherian still needs to pick https://github.com/juliengirault/wikimedia-mapdata/commit/a130b470f83248adb1495186d3959e96ecbe2253

Poking @Yurik

Example affected URL

MaxSem mentioned this in T149268: wikimedia-mapdata needs to be in a canonical location.Oct 26 2016, 11:48 PM

The wrong wgKartographerLiveData GeoJSON code is still existent.

"wgKartographerLiveData":[[],[],[],[],[],[],[],[],[],[],[],[],[],[],...

Change 318435 had a related patch set uploaded (by MaxSem):
Fix missing live groups in Wikivoyage mode

https://gerrit.wikimedia.org/r/318435

gerritbot added a project: Patch-For-Review.Oct 27 2016, 9:40 PM

Change 318435 merged by jenkins-bot:
Fix missing live groups in Wikivoyage mode

https://gerrit.wikimedia.org/r/318435

MaxSem closed this task as Resolved.Oct 27 2016, 10:24 PM

K4-713 subscribed.Oct 28 2016, 5:52 PM

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 2 2016, 4:01 PM

<mapframe>/<maplink>: Invalid GeoJSON code in wgKartographerLiveData prevents drawing of maps at WikivoyageClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

<mapframe>/<maplink>: Invalid GeoJSON code in wgKartographerLiveData prevents drawing of maps at Wikivoyage
Closed, ResolvedPublic
Actions