Page MenuHomePhabricator
Create Task
Maniphest T149050

VisualEditor should provide api-user-agent to RESTBase
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

We've added support for a new header in RESTBase in T121823 - Api-User-Agent for better monitoring/understanding of the API consumers, so VisualEditor should identify itself when talking to RESTBase

Details

SubjectRepoBranchLines +/-
Set Api-User-Agent in requests to RESTBase/Parsoidmediawiki/extensions/VisualEditormaster+11 -5
Customize query in gerrit

Related Objects

Event Timeline

• Pchelolo created this task.Oct 24 2016, 9:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 24 2016, 9:55 PM
• Pchelolo mentioned this in T121823: Provide browser-based apps an alternative way to specify the user agent in RESTBase APIs.Oct 24 2016, 9:55 PM
Jdforrester-WMF subscribed.Oct 27 2016, 3:34 PM

We're currently (since T131171: Add user-agent header in your requests to VirtualRestService) setting the User-Agent (to VisualEditor-MediaWiki/1.28.0-wmf.23 or whatever) in the PHP side, but we don't in JS-land; I guess you want it set in both places?

Jdforrester-WMF claimed this task.Oct 27 2016, 3:51 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF triaged this task as Medium priority.Oct 27 2016, 3:55 PM
gerritbot subscribed.Oct 27 2016, 3:56 PM

Change 318312 had a related patch set uploaded (by Jforrester):
Set Api-User-Agent in requests to RESTBase/Parsoid

https://gerrit.wikimedia.org/r/318312

gerritbot added a project: Patch-For-Review.Oct 27 2016, 3:56 PM
gerritbot added a comment.Oct 27 2016, 11:24 PM

Change 318312 merged by jenkins-bot:
Set Api-User-Agent in requests to RESTBase/Parsoid

https://gerrit.wikimedia.org/r/318312

Jdforrester-WMF closed this task as Resolved.Oct 28 2016, 12:14 AM
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)); removed Patch-For-Review.
In T149050#2748563, @Jdforrester-WMF wrote:

We're currently (since T131171: Add user-agent header in your requests to VirtualRestService) setting the User-Agent (to VisualEditor-MediaWiki/1.28.0-wmf.23 or whatever) in the PHP side, but we don't in JS-land; I guess you want it set in both places?

That's what we did; hope that's OK. Will roll out with next week's train.

• Pchelolo added a comment.Oct 28 2016, 12:15 AM

Thank you @Jdforrester-WMF

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 2 2016, 5:00 PM
Jdforrester-WMF removed a project: MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Nov 7 2016, 7:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits