Page MenuHomePhabricator
Create Task
Maniphest T131171

Add user-agent header in your requests to VirtualRestService
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Please see T131075#2157510 -- it looks like you can pass the header to VRS and RESTBase will then forward that to Parsoid. We need this information for attributing log requests to specific upstream clients.

Details

SubjectRepoBranchLines +/-
Set User-Agent in server-side VRS requests to RESTBase/Parsoidmediawiki/extensions/VisualEditormaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.Mar 29 2016, 5:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2016, 5:20 PM
Jdforrester-WMF triaged this task as High priority.Mar 29 2016, 7:59 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Mar 29 2016, 8:27 PM
• AlexMonk-WMF subscribed.Mar 29 2016, 11:19 PM

To clarify, is this to forward the user's user agent, or make up our own one for RB requests that get sent from the server-side?

ssastry added a comment.Mar 29 2016, 11:22 PM
In T131171#2159454, @AlexMonk-WMF wrote:

To clarify, is this to forward the user's user agent, or make up our own one for RB requests that get sent from the server-side?

Latter. We are interested in associating parsoid requests with clients that request them (VE/CX/etc.)

gerritbot subscribed.Mar 30 2016, 12:06 AM

Change 280360 had a related patch set uploaded (by Alex Monk):
Set User-Agent in server-side VRS requests to RESTBase/Parsoid

https://gerrit.wikimedia.org/r/280360

gerritbot added a project: Patch-For-Review.Mar 30 2016, 12:06 AM
Jdforrester-WMF closed this task as Resolved.Mar 31 2016, 8:30 AM
Jdforrester-WMF assigned this task to • AlexMonk-WMF.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Mar 31 2016, 8:39 AM

Change 280360 merged by jenkins-bot:
Set User-Agent in server-side VRS requests to RESTBase/Parsoid

https://gerrit.wikimedia.org/r/280360

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)).Mar 31 2016, 9:02 AM
Jdforrester-WMF mentioned this in T149050: VisualEditor should provide api-user-agent to RESTBase.Oct 27 2016, 3:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL