Page MenuHomePhabricator
Create Task
Maniphest T149159

[Bug] GeoData\Searcher fatal error in 1.28-wmf.23
Closed, ResolvedPublic
Actions

Description

Fatal error: Class GeoData\Searcher contains abstract method (newLog) and must therefore be declared abstract or implement the remaining methods in /srv/mediawiki/php-1.28.0-wmf.23/extensions/GeoData/includes/Searcher.php on line

Seems related to https://gerrit.wikimedia.org/r/#/c/314350/

Details

SubjectRepoBranchLines +/-
Fix fatalmediawiki/extensions/GeoDatawmf/1.28.0-wmf.23+16 -6
Fix fatalmediawiki/extensions/GeoDatamaster+16 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Matanya created this task.Oct 26 2016, 5:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2016, 5:03 AM
Matanya added a parent task: T147517: MW-1.28.0-wmf.23 deployment blockers.Oct 26 2016, 5:04 AM
MaxSem added a project: Maps-Sprint.Oct 26 2016, 5:15 AM
greg subscribed.Oct 26 2016, 5:17 PM

Was this transient? I don't see it happening after 22:30 UTC yesterday:
https://logstash.wikimedia.org/goto/08f19c169021bd0227fc5c7b224299af

greg added a comment.Oct 26 2016, 5:19 PM

Marking as not a blocker for now.

greg removed a parent task: T147517: MW-1.28.0-wmf.23 deployment blockers.Oct 26 2016, 5:19 PM
MaxSem subscribed.Oct 26 2016, 5:44 PM

Well, the extension being barely used on group0 hosts doesn't mean it doesn't fatal. Get to group1 and you'll see ;)

gerritbot subscribed.Oct 26 2016, 6:01 PM

Change 318136 had a related patch set uploaded (by MaxSem):
Fix fatal

https://gerrit.wikimedia.org/r/318136

gerritbot added a project: Patch-For-Review.Oct 26 2016, 6:01 PM
MaxSem claimed this task.Oct 26 2016, 6:03 PM
MaxSem added a parent task: T147517: MW-1.28.0-wmf.23 deployment blockers.
gerritbot added a comment.Oct 26 2016, 6:11 PM

Change 318138 had a related patch set uploaded (by MaxSem):
Fix fatal

https://gerrit.wikimedia.org/r/318138

gerritbot added a comment.Oct 26 2016, 6:17 PM

Change 318136 merged by jenkins-bot:
Fix fatal

https://gerrit.wikimedia.org/r/318136

gerritbot added a comment.Oct 26 2016, 6:19 PM

Change 318138 merged by MaxSem:
Fix fatal

https://gerrit.wikimedia.org/r/318138

MaxSem closed this task as Resolved.Oct 26 2016, 6:21 PM
ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)), MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 26 2016, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits