Page MenuHomePhabricator

logspam from mediawiki - LoadBalancer::{closure}: found writes/callbacks pending.
Closed, ResolvedPublicPRODUCTION ERROR

Description

This appears to be a new error since I deployed 1.28.0-wmf.23 to group 2.

kibana graph

Raw log json:

{
  "_index": "logstash-2016.10.27",
  "_type": "mediawiki",
  "_id": "AVgHoAgojKHLXmxCbu3m",
  "_score": null,
  "_source": {
    "message": "LoadBalancer::{closure}: found writes/callbacks pending.",
    "@version": 1,
    "@timestamp": "2016-10-27T19:31:17.000Z",
    "type": "mediawiki",
    "host": "mw1167",
    "level": "ERROR",
    "tags": [
      "syslog",
      "es",
      "es"
    ],
    "channel": "DBQuery",
    "normalized_message": "LoadBalancer::{closure}: found writes/callbacks pending.",
    "url": "/rpc/RunJobs.php?wiki=cawiki&type=refreshLinks&maxtime=30&maxmem=300M",
    "ip": "127.0.0.1",
    "http_method": "POST",
    "server": "127.0.0.1",
    "referrer": null,
    "wiki": "cawiki",
    "mwversion": "1.28.0-wmf.23",
    "reqId": "0bbe9732ac71d1d1d75f25ba"
  }

Event Timeline

Ok after giving it more time the spike in error frequency was just an anomaly around the time of deployment. It went back down to fairly low levels now. So this is apparently not directly related to wmf.23

mmodell renamed this task from mediawiki error in 1.28.0-wmf.23: LoadBalancer::{closure}: found writes/callbacks pending. to logspam from mediawiki - LoadBalancer::{closure}: found writes/callbacks pending..Oct 27 2016, 7:49 PM
mmodell triaged this task as Medium priority.
mmodell updated the task description. (Show Details)

While this might be useful for debugging and catching issues with db transactions, maybe it should be downgraded to a warning in production to avoid spamming the error logs? This kind of thing is just a distraction during deployments when we need to be able to make quick judgements about the state of the branch. Some of the only signals we have are fatalmonitor and mediawiki-errors in logstash, so spam in the logs is a fairly big problem.

While this might be useful for debugging and catching issues with db transactions

Can someone exaplain what this is? If it is what I think it says, this should be an INFO or DEBUG, not ERROR. It spams other errors on the dbquery log, so +1 on mmodell comment.

Change 361481 had a related patch set uploaded (by 20after4; owner: 20after4):
[mediawiki/core@master] Downgrade 'found writes/callbacks pending.' from error to info

https://gerrit.wikimedia.org/r/361481

Change 361481 merged by jenkins-bot:
[mediawiki/core@master] Downgrade 'found writes/callbacks pending.' from error to info

https://gerrit.wikimedia.org/r/361481

Change 361733 had a related patch set uploaded (by 20after4; owner: 20after4):
[mediawiki/core@wmf/1.30.0-wmf.7] Downgrade 'found writes/callbacks pending.' from error to info

https://gerrit.wikimedia.org/r/361733

Change 361733 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.7] Downgrade 'found writes/callbacks pending.' from error to info

https://gerrit.wikimedia.org/r/361733

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM