Page MenuHomePhabricator
Create Task
Maniphest T149363

Discussion is broken on Mac mobile Web site
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Nicholas.tsg
Authored By
• jmatazzoni
Oct 27 2016, 8:16 PM
Tags
Referenced Files
F4869401: iPad Mini (iOS 7.1.2).PNG
Nov 27 2016, 9:46 PM
F4869403: T149363 iPad Air 2 (iOS 10.2).PNG
Nov 27 2016, 9:46 PM
F4708427: T149363 IOS 10.0.2 (Chrome).MOV
Nov 8 2016, 10:55 PM
F4708429: T149363 Android 4.4.2 (Chrome).MOV
Nov 8 2016, 10:55 PM
F4667868: IMG_1235.PNG
Oct 27 2016, 8:24 PM
Subscribers
Aklapper
• bmansurov
gerritbot
Jay8g
Jdlrobson
• jmatazzoni
Luke081515
View All 12 Subscribers

Description

Test plan

  • On IOS 10.0.2 and Chrome browser, go to the mobile web site and login.
  • Go to https://en.m.wikipedia.beta.wmflabs.org/wiki/Barack_Obama and scroll to the bottom. Click on the Discussion button.
  • On the Talk page, click to contribute to a discussion.
  • A Reply text box appears. Click into the text box, and a keyboard appears BUT
  • The text box disappears.

Also, please test on iOS 5, 6, 7, 8, and 9.

You can type, and your typing will be visible once you click back on the page to close the keyboard. But this isn't helpful because you can't see the text box you're typing into, nor can you scroll down to view it. It is hidden as long as the keyboard is visible.

BTW, I tried to do this in Safari browser, and couldn't because no Talk page button was displayed at all. Is that a separate bug?

Details

SubjectRepoBranchLines +/-
Fix for ios talk overlay when virtual keyboard openmediawiki/extensions/MobileFrontendmaster+15 -11
Customize query in gerrit

Related Objects

Event Timeline

• jmatazzoni created this task.Oct 27 2016, 8:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2016, 8:16 PM
• jmatazzoni added a comment.EditedOct 27 2016, 8:24 PM

I just noticed that when I encountered the issue above, I was in some kind of unnamed mode. I can tell this because I now see a link waaaaay at the bottom of the page that says "Read as wiki page." See screenshot attached. (Since it appears I wasn't looking at a "wiki page," I'd be curious to know what I was looking at? I don't have mobile Beta enabled...)

IMG_1235.PNG (1×750 px, 50 KB)

• jmatazzoni triaged this task as Unbreak Now! priority.Oct 27 2016, 8:27 PM
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptOct 27 2016, 8:27 PM
ovasileva added a project: Web-Team-Backlog.Nov 1 2016, 2:36 PM
ovasileva moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Nov 1 2016, 2:41 PM
ovasileva moved this task from Upcoming to Incoming on the Web-Team-Backlog board.
Zppix subscribed.Nov 1 2016, 2:42 PM

confirmed on later version of IOS 8.1

phuedx subscribed.Nov 1 2016, 3:38 PM

Thanks for the bug report @jmatazzoni!

BTW, I tried to do this in Safari browser, and couldn't because no Talk page button was displayed at all. Is that a separate bug?

I've been able to start a conversation and respond to it on Safari for iOS 10.1. I can confirm that I see the Talk button on mainspace pages in the same browser.

ovasileva lowered the priority of this task from Unbreak Now! to Medium.Nov 1 2016, 4:38 PM
ovasileva moved this task from Incoming to QA Tasks / Needs Reproduction on the Web-Team-Backlog board.Nov 2 2016, 2:37 PM
Jdlrobson added a comment.Nov 2 2016, 5:32 PM

This smells a lot like T129360. It reuses a lot of the same code as the editor.

phuedx added a subscriber: ovasileva.Nov 2 2016, 6:36 PM

This happens in Chrome (54.0.2840.71), Safari (10.0.1), and Firefox (49.0.2) on macOS Sierra (10.12.1). T149363#2760085 is still relevant.

@ovasileva: I'd recommend raising the priority to UBN!

ovasileva added a comment.Nov 2 2016, 6:38 PM

@phuedx - done, also lining up for sprint + 1

ovasileva raised the priority of this task from Medium to Unbreak Now!.Nov 2 2016, 6:39 PM
ovasileva added a project: Reading-Web-Sprint-85-💩.
ovasileva moved this task from QA Tasks / Needs Reproduction to Upcoming on the Web-Team-Backlog board.
Jdlrobson added a comment.Nov 2 2016, 7:09 PM

Id recommend high at most. This doesnt seem to meet the definition of unbreak now which is drop everything to fix. (The fact you out this in next sprint and not this one proves that it's not :))

phuedx added a comment.Nov 3 2016, 9:33 AM
This comment was removed by phuedx.
ovasileva lowered the priority of this task from Unbreak Now! to High.Nov 7 2016, 5:21 PM
ovasileva moved this task from Needs Analysis to Needs QA on the Reading-Web-Sprint-85-💩 board.
ovasileva set the point value for this task to 3.Nov 7 2016, 5:27 PM
ovasileva moved this task from Upcoming to 2016-17 Q2 on the Web-Team-Backlog board.Nov 7 2016, 6:38 PM
ovasileva added a subscriber: Nicholas.tsg.Nov 8 2016, 12:43 PM

@Nicholas.tsg - Hi Nicholas - we were hoping you could help us with reproducing this bug through various devices/browsers (in addition to the ones stated above)

Nicholas.tsg added a comment.Nov 8 2016, 10:55 PM

This is still an issue in Chrome as seen in two videos I've attached,

iOS 10.0.2 (iPhone)

T149363 IOS 10.0.2 (Chrome).MOV3 MBDownload

and

Android 4.4.2 (Galaxy SIII)

T149363 Android 4.4.2 (Chrome).MOV5 MBDownload

This as far as I've noticed was a Chrome-specific situation and I haven't noticed it in other browser apps such as iOS's Safari or Android's Internet Browser.

Nicholas.tsg moved this task from Needs QA to Needs More Work on the Reading-Web-Sprint-85-💩 board.Nov 8 2016, 10:56 PM
ovasileva moved this task from Needs More Work to Needs Analysis on the Reading-Web-Sprint-85-💩 board.Nov 9 2016, 10:21 AM

moving back to needs analysis

ovasileva moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-85-💩 board.Nov 9 2016, 6:20 PM
• bmansurov subscribed.Nov 11 2016, 10:22 PM

So the problem is the keyboard covers the textbox and doesn't shift the viewport when it's visible.

Jdlrobson added a comment.Nov 14 2016, 9:13 AM

Note this could be related to T148794 due to the positioning/dimension issues we are seeing there.

Jdlrobson claimed this task.Nov 17 2016, 3:11 PM
Jdlrobson moved this task from To Do to Blocked Externally on the Reading-Web-Sprint-85-💩 board.
Jdlrobson moved this task from Blocked Externally to Doing on the Reading-Web-Sprint-85-💩 board.
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-85-💩 board.Nov 17 2016, 3:50 PM
gerritbot subscribed.Nov 17 2016, 3:51 PM

Change 322117 had a related patch set uploaded (by Jdlrobson):
Limit ios header hack to older versions

https://gerrit.wikimedia.org/r/322117

gerritbot added a project: Patch-For-Review.Nov 17 2016, 3:51 PM
• bmansurov moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-85-💩 board.Nov 17 2016, 11:56 PM
Jdlrobson moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-85-💩 board.Nov 18 2016, 12:48 PM
ovasileva added a project: Reading-Web-Sprint-86-🔪🦃.Nov 21 2016, 5:05 PM
Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-86-🔪🦃 board.Nov 21 2016, 5:12 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-86-🔪🦃 board.Nov 21 2016, 6:47 PM
Jdlrobson moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-86-🔪🦃 board.Nov 21 2016, 6:57 PM
Jdlrobson added a comment.Nov 21 2016, 7:08 PM

Waiting for reply from @bmansurov before going ahead and fixing up Limit ios header hack to older versions but precursor patch Scope talk styles to talk overlay is ready to go!

• bmansurov reassigned this task from Jdlrobson to Nicholas.tsg.Nov 21 2016, 9:03 PM
• bmansurov updated the task description. (Show Details)
• bmansurov moved this task from Code Review to Needs QA on the Reading-Web-Sprint-86-🔪🦃 board.
• bmansurov updated the task description. (Show Details)
gerritbot added a comment.Nov 21 2016, 9:36 PM

Change 322117 merged by jenkins-bot:
Fix for ios talk overlay when virtual keyboard open

https://gerrit.wikimedia.org/r/322117

• bmansurov updated the task description. (Show Details)Nov 21 2016, 10:08 PM
• bmansurov updated the task description. (Show Details)
Jdlrobson removed a project: Patch-For-Review.Nov 22 2016, 6:51 PM
Nicholas.tsg added a comment.Nov 27 2016, 9:46 PM

This appears to be fixed in Chrome as seen in the following screencaps for
iOS 7

iPad Mini (iOS 7.1.2).PNG (2×1 px, 246 KB)

and
iOS 10.2
T149363 iPad Air 2 (iOS 10.2).PNG (2×1 px, 158 KB)

Nicholas.tsg moved this task from Needs QA to Ready for Signoff on the Reading-Web-Sprint-86-🔪🦃 board.Nov 27 2016, 9:47 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 27 2016, 11:01 PM
ovasileva closed this task as Resolved.Nov 28 2016, 11:55 AM
Jdlrobson mentioned this in T129360: Virtual keyboard hides the text in iOS mobile wikitext editing.Apr 2 2018, 5:59 PM
Jdlrobson mentioned this in T211490: iPad: scrolling is broken when editing mobile site in source mode.Dec 17 2018, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits