Page MenuHomePhabricator
Create Task
Maniphest T149802

recurring contribution queue monitoring is broken since overhaul
Closed, ResolvedPublic
Actions

Description

We monitor on the master database for recurring queue bloat via nagios/icinga custom plugin "check_fundraising_jobs". Some of the queries need to be rewritten because of schema changes, for example:

DBD::mysql::db selectrow_array failed: Unknown column 'next_sched_contribution' in 'where clause' at /usr/lib/nagios/plugins//check_fundraising_jobs line 94.

I can make the changes but I will need some help from fr-tech folks familiar with the schema changes to adjust the queries.

Event Timeline

Jgreen created this task.Nov 2 2016, 1:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2016, 1:46 PM
Jgreen triaged this task as Unbreak Now! priority.Nov 2 2016, 1:46 PM
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptNov 2 2016, 1:46 PM
Jgreen added a comment.Nov 2 2016, 2:11 PM

It looks like the column 'next_sched_contribution' may just have been renamed, queries adjusted and it ~looks~ right. @Ejegg @cwdent is this correct?

• DStrine moved this task from Triage to FR-Ops on the Fundraising-Backlog board.Nov 2 2016, 4:57 PM
Eileenmcnaughton added a comment.Nov 2 2016, 8:00 PM

that column was renamed - but a long time ago so I'm a bit confused

Jgreen added a comment.Nov 2 2016, 8:10 PM

I noticed this today when I fixed a screwy mail filter and started seeing
cronspam I had been missing. The nagios test has probably been returning a
queue size of '0' since the schema change.

Eileenmcnaughton added a comment.Nov 2 2016, 8:21 PM

It might have been nearly a year ago....

Jgreen added a comment.Nov 2 2016, 8:31 PM

Yup, so we've had no monitoring of that queue since whenever this change
happened.

Eileenmcnaughton added a comment.Nov 2 2016, 8:46 PM

OK - well I can definitely confirm the field name changed from next_sched_contribution to next_sched_contribution_date - probably late last year

Jgreen closed this task as Resolved.Nov 7 2016, 8:14 PM

This is fixed.

Dwisehaupt moved this task from Triage to Done on the fundraising-tech-ops board.Feb 13 2020, 9:30 PM
Restricted Application added a subscriber: Pcoombe. · View Herald TranscriptFeb 13 2020, 9:30 PM
TerraCodes unsubscribed.Feb 13 2020, 10:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL