Page MenuHomePhabricator
Create Task
Maniphest T150148

<maplink> does not work on "Modern" skin
Closed, ResolvedPublic
Actions

Description

Switch skin to modern, and try clicking on any maplinks. The links are not enabled.

It appears the reason is that $( '.mw-kartographer-maplink', '#content' ) fails because there are no tags with content ID in the Modern skin. Instead, there is a mw_content ID, and a number of others.

Details

SubjectRepoBranchLines +/-
Search .mw-body instead of #content to support all the skinsmediawiki/extensions/Kartographerwmf/1.29.0-wmf.1+2 -2
Search .mw-body instead of #content to support all the skinsmediawiki/extensions/Kartographermaster+2 -2
Customize query in gerrit

Event Timeline

Yurik created this task.Nov 7 2016, 2:38 AM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptNov 7 2016, 2:38 AM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald Transcript
Yurik updated the task description. (Show Details)Nov 7 2016, 3:13 AM
Yurik renamed this task from <maplink> does not work on "modern" skin to <maplink> does not work on "Modern" skin.Nov 7 2016, 6:51 AM
gerritbot subscribed.Nov 7 2016, 10:46 PM

Change 320303 had a related patch set uploaded (by JGirault):
Search .mw-body instead of #content to support all the skins

https://gerrit.wikimedia.org/r/320303

gerritbot added a project: Patch-For-Review.Nov 7 2016, 10:46 PM
• JGirault added a comment.EditedNov 7 2016, 10:46 PM
In T150148#2778251, @gerritbot wrote:

Change 320303 had a related patch set uploaded (by JGirault):
Search .mw-body instead of #content to support all the skins

https://gerrit.wikimedia.org/r/320303

Changed to .mw-body, that should work for all skins:

  • Vector
  • Minerva
  • Cologne Blue
  • Monobook
  • Modern

If not, we can change it to search the entire document, I don't think it's that big of a deal.

gerritbot added a comment.Nov 8 2016, 1:18 AM

Change 320303 merged by jenkins-bot:
Search .mw-body instead of #content to support all the skins

https://gerrit.wikimedia.org/r/320303

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 8 2016, 2:00 AM
Yurik closed this task as Resolved.Nov 8 2016, 5:30 AM
Yurik claimed this task.
gerritbot added a comment.Nov 8 2016, 5:31 AM

Change 320345 had a related patch set uploaded (by Yurik):
Search .mw-body instead of #content to support all the skins

https://gerrit.wikimedia.org/r/320345

gerritbot added a comment.Nov 8 2016, 1:51 PM

Change 320345 merged by jenkins-bot:
Search .mw-body instead of #content to support all the skins

https://gerrit.wikimedia.org/r/320345

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Nov 8 2016, 2:00 PM
Stashbot subscribed.Nov 8 2016, 3:23 PM

Mentioned in SAL (#wikimedia-operations) [2016-11-08T15:23:52Z] <hashar@tin> Synchronized php-1.29.0-wmf.1/extensions/Kartographer/modules/maplink/maplink.js: Search .mw-body instead of #content to support all the skins - T150148 (duration: 00m 47s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL