Page MenuHomePhabricator

Edits of global bots are not autosighted anymore in fiwiki
Open, Needs TriagePublic

Description

Global bot Xqbot which fixes double redirects stopped being flagged revs autoreviewed 21.10.2016. Bot is still autopatrolled so global bot -flag works in general.

Support for global bot right was added to Flagged Rews at ticket T18792 / 2008 and local workaround is to add local bot right.

Event Timeline

Zache created this task.Nov 13 2016, 9:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 13 2016, 9:38 AM
Stryn added a subscriber: Stryn.Nov 29 2016, 6:13 PM

FlaggedRevs should check with the new User::isBot() function.

Is this still an issue?

Zache added a comment.Aug 7 2019, 8:01 PM

Yes, we removed the local bot flag from Xqbot and its edits are not automatically reviewed.

Thanks for confirming

Maybe just add autoreview to global bots via https://meta.m.wikimedia.org/wiki/Special:GlobalGroupPermissions/global-bot. Any steward can do so. @MarcoAurelio, opinions?

Maybe just add autoreview to global bots via https://meta.m.wikimedia.org/wiki/Special:GlobalGroupPermissions/global-bot. Any steward can do so. @MarcoAurelio, opinions?

I can do that, but looking at T233561 and related tasks, this looks like a Regression. If we need this as a temporary workaround please let me know and I'll add it.

Indeed global bots do not have 'autoreview' permissions. See a comparaison between Xqbot and AvicBot (both global bots, but Xqbot is locally flagged, while AvicBot is not). Only Xqbot has 'autoreview' permissions as part of its local group membership.

I took a look at the global permissions global-bots do have but 'autoreview' is missing from the Meta form so I need to wait until https://gerrit.wikimedia.org/r/547957 gets deployed.

I've added autoreview to the global bot wikiset. Global bots should have as of now its edits automatically marked as reviewed again.