Page MenuHomePhabricator
Create Task
Maniphest T150999

[mobile] Special:Notifications the counter does not display the count
Closed, ResolvedPublic
Actions

Assigned To
• jmatazzoni
Authored By
Etonkovidova
Nov 17 2016, 10:45 PM
Tags
Referenced Files
F4878624: IMG_1875.PNG
Nov 28 2016, 9:04 PM
F4738236: IMG_1864.PNG
Nov 17 2016, 10:45 PM
F4738234: IMG_1865.PNG
Nov 17 2016, 10:45 PM
Subscribers
Aklapper
• Catrope
Etonkovidova
gerritbot
• jmatazzoni
Trizek-WMF

Description

  1. Login to a mobile (a emulator is ok too) as a user who has unread notifications.
  2. The Home page has the bell notification icon displaying a number of unread notifications.
  3. Click on the icon - the Notification overlay will be displayed. Click on 'All notifications' to go to Special:Notifications page.
  4. Special:Notifications page displays the bell icon without a number.

The same issue happens you type Special:Notifications in the search bar and go to the page.

IMG_1864.PNG (1×640 px, 84 KB)

  1. Click on the bell icon - the counter will be displayed.

IMG_1865.PNG (1×640 px, 85 KB)

Details

SubjectRepoBranchLines +/-
Don't show the notifications bell button/badge on Special:Notificationsmediawiki/extensions/MobileFrontendmaster+5 -2
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Nov 17 2016, 10:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2016, 10:45 PM
Aklapper renamed this task from [mobile] Special:Notificaitons the counter does not display the count to [mobile] Special:Notifications the counter does not display the count .Nov 17 2016, 11:40 PM
Aklapper added a project: Mobile.
gerritbot subscribed.Nov 24 2016, 3:57 AM

Change 323358 had a related patch set uploaded (by Catrope):
Don't show the notifications bell button/badge on Special:Notifications

https://gerrit.wikimedia.org/r/323358

gerritbot added a project: Patch-For-Review.Nov 24 2016, 3:57 AM
• Catrope edited projects, added Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016); removed Collaboration-Team-Triage.Nov 24 2016, 4:01 AM
• Catrope subscribed.

There was code that tried to make the button with the bell in the top right not be displayed on Special:Notifications on mobile, but it didn't fully work. Instead of preventing the button from appearing, it sabotaged it so that the number wouldn't appear.

I've fixed this code so that the bell button now doesn't appear on the special page at all, which was apparently the intent to begin with. If anyone objects, we can make it appear (and be fully functional) instead, but I think this makes more sense. It also avoids sync problems between the notifications list you see when you click the bell, and the one on the special page itself.

• Catrope moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.Nov 24 2016, 4:02 AM
gerritbot added a comment.Nov 24 2016, 10:24 PM

Change 323358 merged by jenkins-bot:
Don't show the notifications bell button/badge on Special:Notifications

https://gerrit.wikimedia.org/r/323358

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 28 2016, 2:01 AM
Trizek-WMF added a project: User-notice-collaboration.Nov 28 2016, 2:53 PM
Trizek-WMF moved this task from To Triage to Announce in next Collaboration Newsletter on the User-notice-collaboration board.
Etonkovidova added a comment.Nov 28 2016, 9:04 PM

Checked in betalabs - the bell icon is removed

IMG_1875.PNG (1×640 px, 87 KB)
.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.Nov 28 2016, 11:09 PM
• jmatazzoni edited projects, added Collaboration-Team-Triage; removed Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016).Nov 30 2016, 1:52 AM
• jmatazzoni moved this task from Untriaged to Medium-Term Interest on the Collaboration-Team-Triage board.
Trizek-WMF subscribed.Dec 12 2016, 9:54 AM

What is the status for that task? Can I announce it?

Trizek-WMF moved this task from Announce in next Collaboration Newsletter to In current Collaboration Newsletter draft on the User-notice-collaboration board.Dec 12 2016, 10:26 AM
Trizek-WMF moved this task from In current Collaboration Newsletter draft to Announce in next Collaboration Newsletter on the User-notice-collaboration board.Dec 12 2016, 2:34 PM
Trizek-WMF added a comment.Jan 18 2017, 5:01 PM
In T150999#2864289, @Trizek-WMF wrote:

What is the status for that task? Can I announce it?

Ping @Catrope

• Catrope added a subscriber: • jmatazzoni.Mar 8 2017, 4:40 PM

Per Elena's comment on Nov 28, this seems fixed? Not sure why @jmatazzoni moved this from Product Review to the Triage board instead of closing it, that's a strange move.

Trizek-WMF removed a project: User-notice-collaboration.Mar 8 2017, 4:42 PM

It is now too old to be announced.

• jmatazzoni closed this task as Resolved.Mar 8 2017, 6:49 PM
• jmatazzoni claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits