Special:ImportTranslations fails to import new translations
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nemo_bis
	Nov 24 2016, 8:12 PM

Description

Importing edits to existing translations took effect immediately: https://translatewiki.net/w/i.php?title=MediaWiki:Absenteelandlord-desc/it&diff=prev&oldid=7126627

But importing a PO file with new translations had no effect (

ext-gpgmail_it.po1 KBDownload

at https://translatewiki.net/wiki/Special:ImportTranslations).

In T42341#2782876, @Seb35 wrote:

I tried to import translations from a .po file via the web interface Special:ImportTranslations, and it works only when modifying existing messages, not when creating messages.

By diving in the code MessageWebImporter::execute, I see there is a call to self::doAction for existing messages, but there is no such call for non-existant messages, so is it really missing? (I successfully imported new messages from the command line script, my question is really about the web interface.)

To be transparent, this feature is requested by a client, if needed I can write the missing part for the web interface.

In T42341#2788308, @Nikerabbit wrote:

It seems to be a bug, yes.

Details

Subject	Repo	Branch	Lines +/-
Actually import the new translations in Special:ImportTranslations	mediawiki/extensions/Translate	REL1_27	+35 -4
Actually import the new translations in Special:ImportTranslations	mediawiki/extensions/Translate	REL1_28	+35 -4
Actually import the new translations in Special:ImportTranslations	mediawiki/extensions/Translate	master	+35 -4

Customize query in gerrit

Related Objects

Mentioned In: T157679: Exception thrown with an uncommited database transaction: MWCallableUpdate::doUpdate: Flush failed on server(s)
Mentioned Here: T42341: Enable translation import on wikis with Translate extension

Event Timeline

Nemo_bis created this task.Nov 24 2016, 8:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 24 2016, 8:12 PM

Nemo_bis triaged this task as High priority.Nov 24 2016, 8:12 PM

I've been facing this issue looking forward to importing my offline translations from .po file translated locally.

Change 334907 had a related patch set uploaded (by Nemo bis):
Actually import the new translations in Special:ImportTranslations

https://gerrit.wikimedia.org/r/334907

gerritbot added a project: Patch-For-Review.Jan 29 2017, 6:42 PM

Is this change live already? Any estimates when it'll be available in translatewiki.net?

See the patch status: The patch is not merged yet.

Change 334907 merged by jenkins-bot:
Actually import the new translations in Special:ImportTranslations

https://gerrit.wikimedia.org/r/334907

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)).Feb 8 2017, 9:00 AM

Nikerabbit closed this task as Resolved.Feb 8 2017, 12:22 PM

Nikerabbit assigned this task to Nemo_bis.

Nikerabbit removed a project: Patch-For-Review.

I tried importing the workflow goes normal way and I get the message that
import is complete, but does not reflect on contributions. I think it is
not still working or am I too quick to try that out @Translatewiki.net?

I have deployed the fix today. Can you please try again?

Hi Niklas,

It worked like a charm.

@all: Thanks for working on this issue and solving it.

Thanks,
Saroj

Nikerabbit added projects: Language-2017 Sprint 2, Unplanned-Sprint-Work.Feb 9 2017, 11:49 AM

Restricted Application added a project: Language-team January-March 2017. · View Herald TranscriptFeb 9 2017, 11:49 AM

Change 336785 had a related patch set uploaded (by Nemo bis):
Actually import the new translations in Special:ImportTranslations

https://gerrit.wikimedia.org/r/336785

Change 336786 had a related patch set uploaded (by Nemo bis):
Actually import the new translations in Special:ImportTranslations

https://gerrit.wikimedia.org/r/336786

Nemo_bis mentioned this in T157679: Exception thrown with an uncommited database transaction: MWCallableUpdate::doUpdate: Flush failed on server(s).Feb 9 2017, 1:18 PM

Change 336785 merged by jenkins-bot:
Actually import the new translations in Special:ImportTranslations