test_recentchanges_timespan is failing on Travis-CI
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Magul
	Nov 29 2016, 9:42 AM

Description

It looks like it's failing after change introduced in T147416

_______________ TestFactoryGenerator.test_recentchanges_timespan _______________
self = <tests.pagegenerators_tests.TestFactoryGenerator testMethod=test_recentchanges_timespan>
    def test_recentchanges_timespan(self):
        """Test recentchanges generator with offset and duration params."""
        gf = pagegenerators.GeneratorFactory(site=self.site)
        gf.handleArg('-recentchanges:120,70')
        gen = gf.getCombinedGenerator()
        self.assertIsNotNone(gen)
        self.assertRaises(ValueError, gf.handleArg, '-recentchanges:3,2,1')
>       self.assertRaises(ValueError, gf.handleArg, '-recentchanges:-10,20')
E       AssertionError: ValueError not raised
tests/pagegenerators_tests.py:857: AssertionError

CC: @Xqt

Details

	Subject	Repo	Branch	Lines +/-
	Fix for test_recentchanges_timespan	pywikibot/core	master	+5 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Magul	T151145 Make Travis (and Appveyor) pass again
		Resolved		Magul	T151856 test_recentchanges_timespan is failing on Travis-CI

Event Timeline

Magul removed Magul as the assignee of this task.Nov 29 2016, 9:42 AM

Magul created this task.

Magul raised the priority of this task from High to Unbreak Now!.Nov 29 2016, 11:05 AM

Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptNov 29 2016, 11:05 AM

Magul claimed this task.Nov 29 2016, 6:08 PM

Change 324241 had a related patch set uploaded (by Magul):
Fix for test_recentchanges_timespan

https://gerrit.wikimedia.org/r/324241

gerritbot added a project: Patch-For-Review.Nov 29 2016, 6:17 PM

Does not break anything except one test.

@Xqt I will not raise priority here, because that's not solution here, but I believe, that if we want to treat tests as first class citizens (I believe we should and based on extensive testsuite we are trying to do so), we should treat any of new breakage in tests as unbreak now. Otherwise we will end up in situation, where testsuite will be failing always and there will be no benefits of running test continuously, because result will say nothing (cause it always failing).

BTW there is simple fix up there already in gerrit, so if You will find time to review it, I will be grateful.

Dalba closed this task as Resolved.Dec 13 2016, 1:24 AM

Change 324241 merged by jenkins-bot:
Fix for test_recentchanges_timespan