Page MenuHomePhabricator
Create Task
Maniphest T152004

Add preview type to hovercards schema
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Add preview type to hovercards schema. Preview type may either be:

  1. Regular ("Extract") hovercard - hovercard displays preview of the article in question
  2. Generic hovercard - hovercard displays the "there is no preview available" card, currently set for articles with no lead section.

AC

  • The previewType property is added to the Schema:Popups schema.
  • The previewType property is only logged as part of the dismissed and opened actions (ideally but optionally also as part of the tapped settings cog action).
    • N.B. that the "generic" preview doesn't have the cog button.

Details

SubjectRepoBranchLines +/-
model: extract -> pagemediawiki/extensions/Popupsmpga+5 -5
reducers: Add preview type to dismissed eventmediawiki/extensions/Popupsmpga+18 -7
Add type to preview modelmediawiki/extensions/Popupsmpga+42 -9
Make gateway use preview modelmediawiki/extensions/Popupsmpga+50 -184
gateway: Don't create new object for thumbnailmediawiki/extensions/Popupsmpga+5 -8
Introduce preview modelmediawiki/extensions/Popupsmpga+245 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2016, 1:15 PM
ovasileva triaged this task as Medium priority.Nov 30 2016, 1:15 PM
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
• bmansurov subscribed.Dec 2 2016, 9:41 PM

@olliv, could you also add a description for each of the options? That would help us document the schema file as well. Thanks.

ovasileva updated the task description. (Show Details)Dec 5 2016, 11:24 AM

@bmansurov - added. Alternatively, we could make this a boolean and just count if the generic occurs - we want to track how many pages lack "regular" previews

ovasileva removed a project: Reading-Web-Sprint-87-♨️😭.Dec 5 2016, 5:56 PM
• Tbayer subscribed.Dec 19 2016, 5:43 PM
ovasileva added a project: Reading-Web-Sprint-88-¯\_(ツ)_/¯.Dec 19 2016, 6:09 PM
ovasileva added a parent task: T152225: Finish rewriting instrumentation.
phuedx updated the task description. (Show Details)Dec 19 2016, 6:31 PM
phuedx added subscribers: • jhobs, phuedx.

@jhobs: Do those AC make sense?

• jhobs claimed this task.Dec 19 2016, 6:45 PM
• jhobs moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.
In T152004#2887732, @phuedx wrote:

@jhobs: Do those AC make sense?

Yep, looks good.

ovasileva moved this task from Backlog to Doing on the Page-Previews (2016-17-Q2-Goal) board.Dec 19 2016, 8:08 PM
MBinder_WMF moved this task from Triaged but Future to 2016-17 Q2 on the Web-Team-Backlog board.Dec 21 2016, 5:43 PM
phuedx set the point value for this task to 2.Jan 4 2017, 10:26 AM
phuedx mentioned this in T152225: Finish rewriting instrumentation.Jan 4 2017, 12:05 PM
phuedx added a project: Reading-Web-Sprint-89-🎂.Jan 4 2017, 6:10 PM
phuedx moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-89-🎂 board.
• bmansurov removed • jhobs as the assignee of this task.Jan 4 2017, 7:29 PM

Un assigning @jhobs as he doesn't seem to be working on this task.

• bmansurov assigned this task to • jhobs.Jan 5 2017, 6:24 PM

We talked about this card at stand-up. @jhobs said he may have forgotten to link the patch to the task.

@jhobs once you upload your patch, are you planning on continuing on working on this task or should someone else continue?

• jhobs added a comment.Jan 5 2017, 7:11 PM

@bmansurov I'll be continuing work on it (although I don't think there will be many iterations anyways).

MBinder_WMF edited projects, added Page-Previews (2016-17-Q3-Goal); removed Page-Previews (2016-17-Q2-Goal).Jan 5 2017, 7:35 PM
MBinder_WMF moved this task from Backlog to Doing on the Page-Previews (2016-17-Q3-Goal) board.Jan 5 2017, 7:36 PM
gerritbot subscribed.Jan 5 2017, 8:21 PM

Change 330718 had a related patch set uploaded (by Jhobs):
Add previewType to logging data for dismissed action

https://gerrit.wikimedia.org/r/330718

gerritbot added a project: Patch-For-Review.Jan 5 2017, 8:21 PM
• jhobs moved this task from To Do to Code Review on the Reading-Web-Sprint-89-🎂 board.Jan 5 2017, 8:22 PM

@bmansurov I found the patch, but it had rebasing issues so I just abandoned it, rebased it manually, and uploaded a fresh one.

• Tbayer added a comment.Jan 5 2017, 9:26 PM

Sorry for having missed the Dec 19 edit of the task description, but it doesn't quite make sense to only log this for dismissed actions. If we want to track the percentage (or absolute number) of generic vs. regular cards seen by readers, we need to record the preview type for all possible events that can end a card interaction, i.e. dismissed *and* open events (and strictly speaking also tapped settings cog, although that has proven to occur so rarely in the previous experiments that it likely won't affect the result here). See the lower part of the state diagram.

• bmansurov added a comment.Jan 5 2017, 9:28 PM

@Tbayer would you please update the description as you see fit?

• Tbayer added a comment.Jan 5 2017, 9:31 PM

BTW, it would be great if we could make the type names even more self-explanatory. E.g. naming them Extract and Generic instead of presently Page and Generic could save forgetful people like me from having to look up repeatedly which is which ;)

• Tbayer updated the task description. (Show Details)Jan 5 2017, 9:42 PM
In T152004#2920998, @bmansurov wrote:

@Tbayer would you please update the description as you see fit?

Done

• jhobs moved this task from Code Review to Doing on the Reading-Web-Sprint-89-🎂 board.Jan 6 2017, 4:50 PM

I guess it's lucky this didn't get resolved last sprint then.

@Tbayer there's no need for logging it during settings cog events because generic previews don't have the settings cog.

• Tbayer added a comment.Jan 6 2017, 8:12 PM
In T152004#2923698, @jhobs wrote:

....

@Tbayer there's no need for logging it during settings cog events because generic previews don't have the settings cog.

Well yes, the type can be inferred in that case. It would still be the cleaner solution to log it, because it makes the queries easier and because it might help avoid errors in case the design changes at some point in the future in that respect. Then again, as mentioned, it likely won't matter quantitatively.

MBinder_WMF moved this task from 2016-17 Q2 to 2016-17 Q3 on the Web-Team-Backlog board.Jan 9 2017, 7:39 PM
Jdlrobson added a project: Reading-Web-Sprint-90-🍌.Jan 18 2017, 6:15 PM
Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Reading-Web-Sprint-90-🍌 board.
Jdlrobson moved this task from Needs Code Review to Needs More Work on the Reading-Web-Sprint-90-🍌 board.
phuedx moved this task from Doing to Needs More Work on the Reading-Web-Sprint-89-🎂 board.Jan 18 2017, 6:16 PM
phuedx added a comment.Jan 18 2017, 10:37 PM

I've rebased rEPOP19fc1ba6c9d1: Add `previewType` to logging data for `dismissed` action. There's a comment from @bmansurov that's yet to be addressed. I've yet to review it too.

phuedx claimed this task.Jan 19 2017, 11:59 PM
phuedx moved this task from Needs More Work to Doing on the Reading-Web-Sprint-90-🍌 board.

^ Since there's been no movement on this card or rEPOP19fc1ba6c9d1: Add `previewType` to logging data for `dismissed` action for some time…

gerritbot added a comment.Jan 27 2017, 2:39 PM

Change 334652 had a related patch set uploaded (by Phuedx):
Introduce preview model

https://gerrit.wikimedia.org/r/334652

gerritbot added a comment.Jan 27 2017, 2:39 PM

Change 334653 had a related patch set uploaded (by Phuedx):
gateway: Don't create new object for thumbnail

https://gerrit.wikimedia.org/r/334653

gerritbot added a comment.Jan 27 2017, 2:39 PM

Change 334654 had a related patch set uploaded (by Phuedx):
Make gateway use model

https://gerrit.wikimedia.org/r/334654

phuedx added a comment.Jan 27 2017, 2:42 PM

Now that there's a model of a preview, we can now define a preview's "type" in one place and simply add that to the instrumentation. This'll be the last change in the chain.

gerritbot added a comment.Jan 30 2017, 10:07 AM

Change 334993 had a related patch set uploaded (by Phuedx):
Add type to preview model

https://gerrit.wikimedia.org/r/334993

phuedx moved this task from Doing to Needs Code Review on the Reading-Web-Sprint-90-🍌 board.Jan 30 2017, 10:09 AM
phuedx added a comment.Jan 30 2017, 11:06 AM

The end of the chain is here: https://gerrit.wikimedia.org/r/#/q/I941ca556b914d0c009cc8e395660e4d299d08020.

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-90-🍌 board.Jan 30 2017, 10:20 PM
phuedx removed phuedx as the assignee of this task.Jan 31 2017, 1:17 PM
phuedx claimed this task.Jan 31 2017, 1:34 PM
phuedx moved this task from Ready for Signoff to Needs Code Review on the Reading-Web-Sprint-90-🍌 board.
phuedx added a subscriber: Jdlrobson.

@Jdlrobson: There's are more changes in the chain to review 😉

phuedx added a comment.Jan 31 2017, 7:26 PM

@bmansurov: In case you didn't see it, I've responded to your comments. Thanks!

gerritbot added a comment.Jan 31 2017, 9:27 PM

Change 334652 merged by jenkins-bot:
Introduce preview model

https://gerrit.wikimedia.org/r/334652

gerritbot added a comment.Jan 31 2017, 9:28 PM

Change 334653 merged by jenkins-bot:
gateway: Don't create new object for thumbnail

https://gerrit.wikimedia.org/r/334653

gerritbot added a comment.Jan 31 2017, 9:30 PM

Change 334654 merged by jenkins-bot:
Make gateway use preview model

https://gerrit.wikimedia.org/r/334654

gerritbot added a comment.Jan 31 2017, 9:34 PM

Change 334993 merged by jenkins-bot:
Add type to preview model

https://gerrit.wikimedia.org/r/334993

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-90-🍌 board.Jan 31 2017, 9:37 PM
gerritbot added a comment.Jan 31 2017, 9:38 PM

Change 330718 merged by jenkins-bot:
reducers: Add preview type to dismissed event

https://gerrit.wikimedia.org/r/330718

phuedx removed phuedx as the assignee of this task.Feb 1 2017, 10:58 AM
MBinder_WMF added a project: Reading-Web-Sprint-91-🐔🍔.Feb 1 2017, 6:27 PM
ovasileva moved this task from Needs Analysis to Needs More Work on the Reading-Web-Sprint-91-🐔🍔 board.Feb 1 2017, 6:29 PM
phuedx moved this task from Needs More Work to Ready for Signoff on the Reading-Web-Sprint-91-🐔🍔 board.Feb 1 2017, 6:29 PM
phuedx claimed this task.Feb 2 2017, 2:48 PM
phuedx moved this task from Ready for Signoff to Needs More Work on the Reading-Web-Sprint-91-🐔🍔 board.

I observed the following while fiddling with the staging server:

[Popups] Value "extract" for property "previewType" is not one of ["page","generic"]

gerritbot added a comment.Feb 2 2017, 2:55 PM

Change 335657 had a related patch set uploaded (by Phuedx):
model: extract -> page

https://gerrit.wikimedia.org/r/335657

phuedx moved this task from Needs More Work to Needs Code Review on the Reading-Web-Sprint-91-🐔🍔 board.Feb 2 2017, 3:02 PM
gerritbot added a comment.Feb 2 2017, 5:19 PM

Change 335657 merged by jenkins-bot:
model: extract -> page

https://gerrit.wikimedia.org/r/335657

phuedx removed phuedx as the assignee of this task.Feb 2 2017, 5:20 PM
phuedx moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-91-🐔🍔 board.
Jdlrobson removed a project: Patch-For-Review.Feb 2 2017, 5:44 PM
Jdlrobson assigned this task to ovasileva.Feb 8 2017, 8:13 PM
ovasileva reassigned this task from ovasileva to • bmansurov.Feb 9 2017, 1:09 PM

I'm not sure I'm qualified to sign off on this...

• bmansurov closed this task as Resolved.Feb 9 2017, 7:55 PM
• bmansurov removed • bmansurov as the assignee of this task.

Tested by hovering over a link that has an extract and a link that doesn't have an extract. Waited until a popup showed and abandoned before seeing a popup.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits