Finish refactoring/implementing tweaked settings workflow
Closed, ResolvedPublic
Actions

Description

AC

The settings workflow is implemented as specified here: https://www.mediawiki.org/wiki/Beta_Features/Hovercards/Functionality#Settings.
The work is based on the mpga branch of the mediawiki-extensions-Popups repository.

Details

	Subject	Repo	Branch	Lines +/-
	Re-introduce Settings dialog	mediawiki/extensions/Popups	mpga	+264 -249
	Settings dialog	mediawiki/extensions/Popups	mpga	+260 -254

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		phuedx	T149801 [EPIC] Refactor Hovercards (née Popups)
		Resolved		• Jhernandez	T152223 Finish refactoring/implementing tweaked settings workflow

Event Timeline

phuedx created this task.Dec 2 2016, 6:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2016, 6:08 PM

phuedx removed a project: Reading-Web-Sprint-85-💩.Dec 2 2016, 6:12 PM

Change 325283 had a related patch set uploaded (by Phuedx):
Add minimal eventLogging reducer

https://gerrit.wikimedia.org/r/325283

Change 325284 had a related patch set uploaded (by Phuedx):
Hygiene: Extract shared stub user object

https://gerrit.wikimedia.org/r/325284

Change 325285 had a related patch set uploaded (by Phuedx):
Include user's edit count in BOOT action

https://gerrit.wikimedia.org/r/325285

Change 325286 had a related patch set uploaded (by Phuedx):
Include user's preview count in BOOT action

https://gerrit.wikimedia.org/r/325286

Change 325287 had a related patch set uploaded (by Phuedx):
Increment preview count

https://gerrit.wikimedia.org/r/325287

ovasileva added a project: Reading-Web-Sprint-86-🔪🦃.Dec 5 2016, 2:40 PM

ovasileva moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.Dec 5 2016, 3:15 PM

phuedx edited projects, added Reading-Web-Sprint-87-♨️😭; removed Reading-Web-Sprint-86-🔪🦃.Dec 5 2016, 5:17 PM

phuedx moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-87-♨️😭 board.

• jhobs moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-86-🔪🦃 board.Dec 5 2016, 5:17 PM

• jhobs added a project: Reading-Web-Sprint-86-🔪🦃.

Wrong task ID…

• bmansurov moved this task from Uncategorized to Maintainability on the Technical-Debt (RW-Tech-Debt) board.Dec 8 2016, 2:41 PM

Any updates here, @jhobs?

phuedx mentioned this in T152225: Finish rewriting instrumentation.Dec 12 2016, 8:48 AM

Change 326402 had a related patch set uploaded (by Jhobs):
Settings dialog

https://gerrit.wikimedia.org/r/326402

• jhobs moved this task from Doing to Code Review on the Reading-Web-Sprint-86-🔪🦃 board.Dec 12 2016, 9:57 AM

In T152223#2858633, @bmansurov wrote:

Any updates here, @jhobs?

Sorry @bmansurov, I missed this comment initially. Settings stuff is up and looking good, likely to be +2'd into the feature branch today.

Change 326402 merged by jenkins-bot:
Settings dialog

https://gerrit.wikimedia.org/r/326402

Change 326419 had a related patch set uploaded (by Jhernandez):
Re-introduce Settings dialog

https://gerrit.wikimedia.org/r/326419

Thanks for the update, @jhobs!

Jdlrobson moved this task from Doing to Needs More Work on the Reading-Web-Sprint-87-♨️😭 board.Dec 12 2016, 6:18 PM

Change 326419 abandoned by Jhernandez:
Re-introduce Settings dialog

Reason:
Abandoning.

This patch is being re-introduce as a series of smaller focused commits with better tests at https://gerrit.wikimedia.org/r/#/c/326512/ and the followup commits.

https://gerrit.wikimedia.org/r/326419

phuedx reassigned this task from • jhobs to • Jhernandez.Dec 13 2016, 9:52 AM

This was done in rEPOPae22a00dc88a: Move settings images and styles to ext.popups/ through rEPOP68f04d62ec7a: Wire settings dialog to show on SETTINGS_SHOW action.