Page MenuHomePhabricator
Create Task
Maniphest T152524

CX template editor for inline template editor takes the whole screen
Closed, ResolvedPublic
Actions

Description

To reproduce:

  • Translate "User:Amire80/IPA template" from English to German
  • In the first paragraph, click "/bla/". This is an IPA template. Click it again to edit it.

Observed: The template editor takes the full screen, even though there is only one parameter in this template.

Expected: It must look according to the design at T144004.

Details

SubjectRepoBranchLines +/-
Fix: Inline template editor goes full screen widthmediawiki/extensions/ContentTranslationwmf/1.29.0-wmf.5+7 -1
Fix: Inline template editor goes full screen widthmediawiki/extensions/ContentTranslationmaster+7 -1
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Dec 6 2016, 7:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2016, 7:44 PM
Amire80 triaged this task as High priority.Dec 6 2016, 8:37 PM
Amire80 added a project: Language-Q2-2016-17 Sprint 5.
Restricted Application added a project: Language-Engineering October-December 2016. · View Herald TranscriptDec 6 2016, 8:37 PM
santhosh renamed this task from CX template editor for inline IPA template editor takes the whole screen to CX template editor for inline template editor takes the whole screen.Dec 7 2016, 4:50 AM
santhosh claimed this task.
gerritbot subscribed.Dec 7 2016, 4:50 AM

Change 325734 had a related patch set uploaded (by Santhosh):
Fix: Inline template editor goes full screen width

https://gerrit.wikimedia.org/r/325734

gerritbot added a project: Patch-For-Review.Dec 7 2016, 4:50 AM
santhosh moved this task from Backlog to In Review on the Language-Q2-2016-17 Sprint 5 board.Dec 7 2016, 4:52 AM
santhosh added a comment.Dec 7 2016, 4:55 AM

Before:

pasted_file (599×1 px, 38 KB)

After:

pasted_file (247×1 px, 19 KB)

gerritbot added a comment.Dec 7 2016, 8:06 AM

Change 325734 merged by jenkins-bot:
Fix: Inline template editor goes full screen width

https://gerrit.wikimedia.org/r/325734

Nikerabbit removed a project: Patch-For-Review.Dec 7 2016, 8:07 AM
Nikerabbit moved this task from In Review to QA on the Language-Q2-2016-17 Sprint 5 board.
gerritbot added a comment.Dec 7 2016, 8:49 AM

Change 325747 had a related patch set uploaded (by Amire80):
Fix: Inline template editor goes full screen width

https://gerrit.wikimedia.org/r/325747

gerritbot added a project: Patch-For-Review.Dec 7 2016, 8:49 AM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 7 2016, 9:00 AM
gerritbot added a comment.Dec 7 2016, 2:02 PM

Change 325747 merged by jenkins-bot:
Fix: Inline template editor goes full screen width

https://gerrit.wikimedia.org/r/325747

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Dec 7 2016, 3:00 PM
Amire80 moved this task from QA to Done on the Language-Q2-2016-17 Sprint 5 board.Dec 7 2016, 9:14 PM

Verified in production. Thanks for the fix!

Amire80 removed a project: Patch-For-Review.Dec 7 2016, 9:15 PM
Amire80 mentioned this in T144004: Support inline template adaptation.Dec 7 2016, 9:29 PM
Arrbee closed this task as Resolved.Dec 20 2016, 7:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL