Popup menus etc. fail in conjunction with jQuery 3. Using jquery-migrate, the following message is obtained:
JQMIGRATE: jQuery.fn.offset() requires a valid DOM element
The trace leads to OO.ui.mixin.ClippableElement.clip:
$scrollableContainer = this.$clippableScrollableContainer.is( 'html, body' ) ? this.$clippableWindow : this.$clippableScrollableContainer;
scOffset = $scrollableContainer.offset() || { top: 0, left: 0 };(oojs-ui-core.js line 4108)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| ClippableElement: Compatibility with jQuery 3 | oojs/ui | master | +7 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Krinkle | T127328 Optimise critical rendering path | |||
| Resolved | Krinkle | T124742 Upgrade to jQuery 3 | |||
| Resolved | matmarex | T160802 Resolve jQuery 3 migration errors in OOjs UI | |||
| Resolved | matmarex | T152778 ClippableElement not compatible with jQuery 3.0 |
The simplified problem is that $( window ).offset() returns undefined in jQuery 1, and throws an exception in jQuery 3. We can easily change the code to avoid relying on this.
Change 326129 had a related patch set uploaded (by Bartosz Dziewoński):
ClippableElement: Compatibility with jQuery 3