Page MenuHomePhabricator

Selector logic link in Special:CentralNoticeBanners links to a 404 page
Open, Needs TriagePublic

Description

https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/modules/ext.centralNotice.bannerController/mobile/device.js is 404. It should be updated or removed accordingly.

This file was deleted in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/221759, no idea what to replace.

replication steps

  • get a mediawiki instance with centralnotice installed
  • visit Special:CentralNoticeBanners.
  • click the link to a random banner (example)
  • Found the "Selector logic" link in Settings > Display on

what needs to change

Please update the URL in https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/ed8a7c3b8e92a48f7c4286360bc91dce86148345/i18n/en.json#L210

Event Timeline

6 years for such a small thing, wow.

As someone who doesn't know CentralNotice could someone explain what this is about? This seems like a good candidate for good first task only but the problem doesn't seem to be well defined.

The url 404s because it's a bad URL and should be
https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/resources/ext.centralNotice.bannerController/mobile/device.js

Presumably something links to it? Is there a screenshot or code that can give a clue to a volunteer about how to fix it?

@Jdlrobson, there are some additional details in the linked duplicate bug, and there is link to the position in code where the change needs to be done in the comment above.