Page MenuHomePhabricator
Create Task
Maniphest T153277

Links in show preview resolve to wrong URL in NWE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Use show preview on a sub page (e.g. User:Foo/Sandbox)

Reported on https://www.mediawiki.org/w/index.php?title=Topic:Tg9lh7gjubuym82q&topic_showPostId=th7atmo2i2iph7cy#flow-post-th7atmo2i2iph7cy

Details

SubjectRepoBranchLines +/-
Resolve URLs in show preview against correct basemediawiki/extensions/VisualEditorwmf/1.29.0-wmf.6+10 -4
Resolve URLs in show preview against correct basemediawiki/extensions/VisualEditormaster+10 -4
Customize query in gerrit

Event Timeline

• Esanders created this task.Dec 15 2016, 2:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2016, 2:42 AM
Catrope subscribed.Dec 15 2016, 2:49 AM

I can also get it to render URLs like /w/Foo , if I middle-click on the edit button (so my URL is /w/index.php?...) and preview a link to Foo.

Perhaps this should use PreviewElement or borrow its tricks?

Jdforrester-WMF triaged this task as Medium priority.Dec 15 2016, 2:51 AM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
gerritbot subscribed.Dec 15 2016, 2:57 AM

Change 327425 had a related patch set uploaded (by Esanders):
Resolve URLs in show preview against correct base

https://gerrit.wikimedia.org/r/327425

gerritbot added a project: Patch-For-Review.Dec 15 2016, 2:57 AM
gerritbot added a comment.Dec 15 2016, 3:32 AM

Change 327425 merged by jenkins-bot:
Resolve URLs in show preview against correct base

https://gerrit.wikimedia.org/r/327425

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 15 2016, 4:00 AM
gerritbot added a comment.Dec 15 2016, 4:24 AM

Change 327429 had a related patch set uploaded (by Jforrester):
Resolve URLs in show preview against correct base

https://gerrit.wikimedia.org/r/327429

gerritbot added a comment.Dec 15 2016, 7:13 PM

Change 327429 merged by jenkins-bot:
Resolve URLs in show preview against correct base

https://gerrit.wikimedia.org/r/327429

Jdforrester-WMF closed this task as Resolved.Dec 15 2016, 7:18 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)); removed Patch-For-Review.
Jdforrester-WMF subscribed.

Now deployed to wmf.6, so will be fixed everywhere within the next hour or so.

Stashbot subscribed.Dec 15 2016, 7:20 PM

Mentioned in SAL (#wikimedia-operations) [2016-12-15T19:20:01Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.6/extensions/VisualEditor/modules/ve-mw: SWAT: [[gerrit:327429|Resolve URLs in show preview against correct base]] T153277 (duration: 00m 40s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits