Page MenuHomePhabricator

Links in show preview resolve to wrong URL in NWE
Closed, ResolvedPublic1 Story Points

Event Timeline

Esanders created this task.Dec 15 2016, 2:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2016, 2:42 AM

I can also get it to render URLs like /w/Foo , if I middle-click on the edit button (so my URL is /w/index.php?...) and preview a link to Foo.

Perhaps this should use PreviewElement or borrow its tricks?

Jdforrester-WMF triaged this task as Normal priority.Dec 15 2016, 2:51 AM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

Change 327425 had a related patch set uploaded (by Esanders):
Resolve URLs in show preview against correct base

https://gerrit.wikimedia.org/r/327425

Change 327425 merged by jenkins-bot:
Resolve URLs in show preview against correct base

https://gerrit.wikimedia.org/r/327425

Change 327429 had a related patch set uploaded (by Jforrester):
Resolve URLs in show preview against correct base

https://gerrit.wikimedia.org/r/327429

Change 327429 merged by jenkins-bot:
Resolve URLs in show preview against correct base

https://gerrit.wikimedia.org/r/327429

Jdforrester-WMF closed this task as Resolved.Dec 15 2016, 7:18 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Now deployed to wmf.6, so will be fixed everywhere within the next hour or so.

Mentioned in SAL (#wikimedia-operations) [2016-12-15T19:20:01Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.6/extensions/VisualEditor/modules/ve-mw: SWAT: [[gerrit:327429|Resolve URLs in show preview against correct base]] T153277 (duration: 00m 40s)