KeyError: u'this-property-does-not-exist' on Travis CI
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Magul
	Dec 15 2016, 4:14 PM

Description

======================================================================
ERROR: test_not_exists (tests.site_tests.TestSiteInfo)
Test accessing a property not in siteinfo.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/wikimedia/pywikibot-core/tests/site_tests.py", line 2210, in test_not_exists
    self.assertEqual(len(mysite.siteinfo.get(not_exists)), 0)
  File "/home/travis/build/wikimedia/pywikibot-core/pywikibot/site.py", line 1678, in get
    preloaded = self._get_siteinfo(key, expiry)[key]
KeyError: u'this-property-does-not-exist'

see: https://travis-ci.org/wikimedia/pywikibot-core/jobs/184242117#L4477-L4486

Details

	Subject	Repo	Branch	Lines +/-
	Fix regex for error message in siteinfo request	pywikibot/core	master	+2 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Magul	T151145 Make Travis (and Appveyor) pass again
Open	None	T152598 Check Pywikibot for Mediawiki api Error code and other message reporting changes
Resolved	Magul	T153325 KeyError: u'this-property-does-not-exist' on Travis CI

Event Timeline

Magul created this task.Dec 15 2016, 4:14 PM

I checked on older commit and it also is raising this error (which haven't been raised before). It looks, that some change on zh.wikisource occurs in between.

On en.wiki problem doesn't occurs. Raw API message from this test looks like:

url	message
en.wiki	Unrecognized value for parameter 'siprop': this-property-does-not-exist
zh.wikisource	Unrecognized value for parameter "siprop": this-property-does-not-exist.

Magul added a comment.Dec 15 2016, 4:55 PM

This comment was removed by Magul.

It looks like regression introduced in MW. I will update regex here, but we need to figure out how to not depend on message (is it going to pass code of an error)?

Change 327551 had a related patch set uploaded (by Magul):
Fix regex for error message in siteinfo request

https://gerrit.wikimedia.org/r/327551

gerritbot added a project: Patch-For-Review.Dec 15 2016, 5:39 PM

Dalba added a parent task: T152598: Check Pywikibot for Mediawiki api Error code and other message reporting changes.Dec 16 2016, 2:31 AM

Dalba closed this task as Resolved.Dec 16 2016, 7:11 PM

Change 327551 merged by jenkins-bot:
Fix regex for error message in siteinfo request