Maniphest T153429

[Bug] Some coordinate values display 60 seconds instead of rounding to 1 minute
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	thiemowmde
	Dec 16 2016, 10:36 AM

Tags

Referenced Files

None

Subscribers

• Aleksey_WMDE

View All 14 Subscribers

Description

52.4 is formatted as 52°23'60" with certain precisions. Reported here: https://www.wikidata.org/wiki/Property_talk:P625#Why_is_60_seconds_possible.3F

Patches for review:

https://github.com/DataValues/Geo/pull/90
https://github.com/DataValues/Geo/pull/91
Tag a new release.
~~Possibly update Wikibase.git to use the new release, if it does not happen automatically.~~

Related Objects

Duplicates Merged Here: T75613: [Bug] Rounding errors lead to 60 mins/secs in Geo formatters

Event Timeline

thiemowmde created this task.Dec 16 2016, 10:36 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptDec 16 2016, 10:36 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

thiemowmde triaged this task as Medium priority.Dec 16 2016, 10:36 AM

thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.

thiemowmde moved this task from incoming to in progress on the Wikidata board.

Aschroet subscribed.Dec 16 2016, 11:41 AM

thiemowmde updated the task description. (Show Details)Dec 16 2016, 11:46 AM

thiemowmde closed this task as Resolved.Dec 16 2016, 3:34 PM

thiemowmde updated the task description. (Show Details)

thiemowmde moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.

Jc3s5h subscribed.Dec 16 2016, 5:56 PM

Thank you for the quick bugfix. How can i find out when this is in production?

@Aschroet: The next deployment will happen some time in January. You can check for yourself at https://www.wikidata.org/wiki/Special:Version#mw-version-ext-datavalues-DataValues_Geo. The issue described in this ticket here will be fixed with DataValues Geo version 1.2.1.

thiemowmde merged a task: T75613: [Bug] Rounding errors lead to 60 mins/secs in Geo formatters.Mar 15 2017, 1:12 PM

thiemowmde added subscribers: Ricordisamoa, JeroenDeDauw, Wikidata-bugs, JulesWinnfield-hu.