Page MenuHomePhabricator
Create Task
Maniphest T153628

[Regression 1.28.0-wmf.15] VE does not scroll cursor into view when adding new lines to end of document
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  • open a long page for editing
  • navigate to bottom
  • press enter a few times

The cursor will move down but the viewport will not scroll (so the cursor will leave the visible area), which is not how the browser's native editor behaves.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (460f16c)mediawiki/extensions/VisualEditormaster+1 -1
ui.Surface: scrollCursorIntoView should handle below the screen, tooVisualEditor/VisualEditormaster+24 -17
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Dec 19 2016, 8:22 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 19 2016, 8:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders renamed this task from New wikitext editor does not follow cursor with the scrollbar at bottom of the page to [Regression] VE does not scroll cursor into view when adding new lines to end of document.Dec 19 2016, 8:11 PM
Esanders removed a project: VisualEditor-MediaWiki-2017WikitextEditor.
Esanders updated the task description. (Show Details)
Esanders subscribed.

Edited to make this a generic VE bug, not just wikitext mode.

Esanders added a subscriber: DLynch.Dec 19 2016, 9:37 PM

Bisect blames https://gerrit.wikimedia.org/r/#/c/304575/ @DLynch

gerritbot subscribed.Dec 20 2016, 5:31 PM

Change 328395 had a related patch set uploaded (by DLynch):
ui.Surface: scrollCursorIntoView should handle below the screen, too

https://gerrit.wikimedia.org/r/328395

gerritbot added a project: Patch-For-Review.Dec 20 2016, 5:31 PM
DLynch claimed this task.Dec 20 2016, 5:36 PM
Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.Jan 3 2017, 6:22 PM
Jdforrester-WMF renamed this task from [Regression] VE does not scroll cursor into view when adding new lines to end of document to [Regression 1.28.0-wmf.15] VE does not scroll cursor into view when adding new lines to end of document.Jan 3 2017, 6:34 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a project: VisualEditor-ContentEditable.
gerritbot added a comment.Jan 5 2017, 3:35 PM

Change 328395 merged by jenkins-bot:
ui.Surface: scrollCursorIntoView should handle below the screen, too

https://gerrit.wikimedia.org/r/328395

Jdforrester-WMF removed a project: Patch-For-Review.Jan 5 2017, 4:29 PM
gerritbot added a comment.Jan 10 2017, 6:39 PM

Change 331515 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (460f16c)

https://gerrit.wikimedia.org/r/331515

gerritbot added a project: Patch-For-Review.Jan 10 2017, 6:39 PM
gerritbot added a comment.Jan 10 2017, 7:34 PM

Change 331515 merged by jenkins-bot:
Update VE core submodule to master (460f16c)

https://gerrit.wikimedia.org/r/331515

Jdforrester-WMF closed this task as Resolved.Jan 10 2017, 7:35 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF subscribed.

OK, theoretically this is now fixed.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 10 2017, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL