Page MenuHomePhabricator

Karma qunit should support Chromium
Closed, ResolvedPublic

Description

The MediaWiki karma runner has browser set to Chrome which does not recognize Chromium. Support has been added in karma-chrome-launcher since version 2.0.0.

https://github.com/karma-runner/karma-chrome-launcher/commit/33e8d8269ae793c74e39451380d52bfd9c310783
https://github.com/karma-runner/karma-chrome-launcher/issues/45

That adds support of Chromium on Windows and Darwin.

Event Timeline

hashar created this task.Dec 20 2016, 3:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2016, 3:33 PM

Change 328113 had a related patch set uploaded (by Paladox):
Update some packages

https://gerrit.wikimedia.org/r/328113

Change 328383 had a related patch set uploaded (by Hashar):
build: bump Karma to support Chromium on Darwin/Windows

https://gerrit.wikimedia.org/r/328383

Change 331110 had a related patch set uploaded (by Krinkle):
Update CHROME_BIN to detect chromium on Debian Jessie

https://gerrit.wikimedia.org/r/331110

Change 331110 merged by jenkins-bot:
Update CHROME_BIN to detect chromium on Debian Jessie

https://gerrit.wikimedia.org/r/331110

Change 331159 had a related patch set uploaded (by Paladox):
Fix chromium browser detection on jessie

https://gerrit.wikimedia.org/r/331159

I think the only fix here is to change Chrome to Chromium.

Anyone who has chrome installed locally and notxhromoum can change it to chrome locally to test.

I think the only fix here is to change Chrome to Chromium.
Anyone who has chrome installed locally and notxhromoum can change it to chrome locally to test.

We'll be doing it the other way around. Chrome is set in the Gruntfile configuration for Karma. On CI, we'll override CHROME_BIN to point to our Chromium install. (per fbb536c21a8cb098e5f8b0dc790b13145d615af4).

Change 328383 merged by jenkins-bot:
build: Upgrade karma-chrome-launcher to support Chromium on Mac/Windows

https://gerrit.wikimedia.org/r/328383

Krinkle closed this task as Resolved.Jan 12 2017, 9:54 PM
Krinkle claimed this task.

Change 331159 abandoned by Paladox:
Fix chromium browser detection on jessie

Reason:
I thought this was the reason why it wasn't working. But it is working now :)

https://gerrit.wikimedia.org/r/331159

Thank you very much @Krinkle to have followed up and fixed up this one. Sorry for the lack of follow up on my side :(

Change 328113 abandoned by Reedy:
Update some packages

https://gerrit.wikimedia.org/r/328113