Page MenuHomePhabricator
Create Task
Maniphest T154111

NWE shouldn't mark inserted ISBN with <nowiki> tags
Closed, DuplicatePublic0 Estimated Story Points
Actions

Description

Hi all,
I've noticed NWE marks inserted text with nowiki tags when it contain ISBN. I think this is unwanted behaviour.

SEE T154111#3296950 FOR NEW STEPS, THE STEPW BELOW DO NOT WORK ANYMORE

Steps to reproduce

  1. Open any page at cs.wikipedia.org
  2. Edit the page with NWE
  3. Try to insert EASSEY, George. Esence ájurvédy. Olomouc: Fontána, c2007. ISBN 978-80-7336-398-7.

Current behaviour
NWE cover ISBN to nowiki tags

Expected behaviour
NWE pasts ISBN as it is in original text.

Related Objects

Event Timeline

Urbanecm created this task.Dec 25 2016, 6:09 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 25 2016, 6:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm moved this task from Backlog to Watching on the User-Urbanecm board.Dec 27 2016, 6:22 PM
Jdforrester-WMF closed this task as Resolved.Mar 3 2017, 9:59 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 0.
Jdforrester-WMF subscribed.

Sorry about the slow response; we fixed it last month but I've only now got to this task.

Urbanecm added a comment.Mar 3 2017, 10:03 PM

Thank you, it works.

Urbanecm reopened this task as Open.May 28 2017, 1:24 PM

The bug reappeared for some ISBNs. See the steps below.

Steps to reproduce

  1. Go to citace.com (Czech generator for bibliographic references)
  2. Into the textbox insert ISBN 9788024747354
  3. Click Generovat citaci
  4. Click Ukázat citaci
  5. Select&copy the reference displayed
  6. Go to any page at cs.wikipedia.org
  7. Open it in NWE
  8. Insert the copied reference from step 5 to the page

What should happen
The ISBN is inserted as-is

What happened
The ISBN is covered with <nowiki> tags.

Is it re-appearance of this bug? Or should I fill another task?

Urbanecm updated the task description. (Show Details)May 28 2017, 1:25 PM
Urbanecm added a subscriber: Esanders.
Alsee subscribed.Jun 25 2017, 9:59 PM

I did a little experimentation. It appears this bug is being triggered by T153315. Instead of doing a normal copy-paste, the NewEditor defaults to trying to convert HTML into wikitext. When it sees the italics it triggers HTML->Wikitext conversion. Then nowikis get spammed into your wikitext.

• Deskana subscribed.Jul 26 2017, 9:49 AM

This was fixed in T153315.

• Deskana closed this task as a duplicate of T153315: Pasting annotated wikitext results in double encoding and therefore <nowiki>s.Jul 26 2017, 9:49 AM
Urbanecm removed a project: User-Urbanecm.Oct 18 2018, 11:50 AM
Restricted Application added a subscriber: jeblad. · View Herald TranscriptOct 18 2018, 11:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits