Page MenuHomePhabricator
Create Task
Maniphest T154574

Inject dependencies of ListSubscribers API module
Closed, ResolvedPublic
Actions

Description

Let's have better DI.

Details

SubjectRepoBranchLines +/-
Remove not needed $modulePrefix from ListSubscribers constructormediawiki/extensions/Wikibasemaster+7 -12
Better dependency injection in ListSubscribersmediawiki/extensions/Wikibasemaster+17 -9
Inject dependencies of ListSubscribers API modulemediawiki/extensions/Wikibasemaster+35 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Jan 4 2017, 12:45 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 4 2017, 12:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Jan 4 2017, 12:46 PM

Change 330403 had a related patch set uploaded (by Ladsgroup):
Inject dependencies of ListSubscribers API module

https://gerrit.wikimedia.org/r/330403

gerritbot added a project: Patch-For-Review.Jan 4 2017, 12:46 PM
Ladsgroup moved this task from Incoming to Blocked on others on the User-Ladsgroup board.Jan 5 2017, 10:50 AM
gerritbot added a comment.Jan 6 2017, 10:45 AM

Change 330403 merged by jenkins-bot:
Inject dependencies of ListSubscribers API module

https://gerrit.wikimedia.org/r/330403

Ladsgroup moved this task from Blocked on others to Done on the User-Ladsgroup board.Jan 6 2017, 11:34 AM
Ladsgroup moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Jan 6 2017, 7:55 PM

Change 330985 had a related patch set uploaded (by Ladsgroup):
Better dependency injection in ListSubscribers

https://gerrit.wikimedia.org/r/330985

Ladsgroup moved this task from Done to Blocked on others on the User-Ladsgroup board.Jan 6 2017, 8:15 PM
gerritbot added a comment.Jan 7 2017, 1:44 AM

Change 330985 merged by jenkins-bot:
Better dependency injection in ListSubscribers

https://gerrit.wikimedia.org/r/330985

gerritbot added a comment.Jan 9 2017, 9:32 AM

Change 331238 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove unused ListSubscribers constructor parameter

https://gerrit.wikimedia.org/r/331238

gerritbot added a comment.Jan 9 2017, 12:06 PM

Change 331238 merged by jenkins-bot:
Remove not needed $modulePrefix from ListSubscribers constructor

https://gerrit.wikimedia.org/r/331238

Ladsgroup moved this task from Blocked on others to Done on the User-Ladsgroup board.Jan 10 2017, 2:40 PM
thiemowmde closed this task as Resolved.Jan 11 2017, 4:27 PM
thiemowmde triaged this task as Medium priority.
thiemowmde edited projects, added MediaWiki-extensions-WikibaseRepository, Wikidata; removed Patch-For-Review.
Ladsgroup added a parent task: T158705: Inject dependencies in Wikibase API modules and special pages.Feb 21 2017, 9:16 PM
DannyS712 added a project: Dependency injection.Mar 20 2020, 5:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL