Page MenuHomePhabricator

Message dialogs should be a normal dialog with actual buttons for consistency with rest of interface
Closed, ResolvedPublic

Assigned To
Authored By
Isarra
Jan 17 2017, 8:17 PM
Referenced Files
F5301620: image.png
Jan 17 2017, 8:17 PM
F5301697: image.png
Jan 17 2017, 8:17 PM
F5301624: image.png
Jan 17 2017, 8:17 PM

Description

When cancelling an edit with VE, a dialog pops up asking 'Are you sure?', with different style of buttons (frameless?) from the rest of the dialogs.

For a more consistent experience, it should use the normal dialog that all the tools, the save, etc use, with normal buttons.

Cancel dialog:

image.png (222×372 px, 13 KB)

Normal dialog:

image.png (540×550 px, 19 KB)

Mockup of cancel dialog using normal dialog layout:

image.png (164×513 px, 13 KB)

Event Timeline

matmarex subscribed.

For reference, the first dialog is a OOjs UI MessageDialog, and the second is a OOjs UI ProcessDialog. I don't know why we have them separate.

Esanders renamed this task from VisualEditor cancel confirmation dialog should be a normal dialog with actual buttons for consistency with rest of interface to Message dialogs should be a normal dialog with actual buttons for consistency with rest of interface.Jan 17 2017, 11:17 PM
Esanders removed a project: VisualEditor.
Esanders subscribed.

I disagree, many UIs distinguish between full modal dialogs, and quick message dialogs which are merely prompting for a limited number of actions.

I disagree, many UIs distinguish between full modal dialogs, and quick message dialogs which are merely prompting for a limited number of actions.

Why do they do this? Does that apply here?

It distinguishes between a quick prompt where the user's primary action is just to choose one of the buttons, and a full dialog where the user has to interact with it before moving on to the next step.

Why is this distinction important? Users should still be reading this before agreeing to it, no matter what it is, thus a form of interaction. Or there wouldn't be a point in a dialog appearing in the first place.

Volker_E claimed this task.
Volker_E subscribed.

With T197001: WikimediaUI theme: Alert and message dialog buttons should follow normal button color style and reduce slightly in height in, I'm going to put this on resolved. I agreed with the visual treatment part of this task, which also made it in some form into the fixes of T197001.
The other, not completely resolved question is a fully consistent position of buttons in dialogs, which is better handled in T155528. Design team is aware of that.