Since the developer didn't respond in [0, 1] as the when, by whom the changes where made to the SpecialSearchResults hook, I'll reiterate the issue in this task:
[2, 3] is expecting the ref-by to modify/augment results after they have been fetched in a postFilter process.
- If you need to change the hook signature then please follow .
- If you think those ref-by are inappropriate then please provide examples on how to achieve the same functionality and not just drop a bomb like "... no reason to use by-ref on objects unless the hook is supposed to replace them (this one isn't)".
PS: For an external extension maintainer (like myself) it is utterly annoying that changes are made without considering the wider audience (that are not WMF affiliate).