Page MenuHomePhabricator
Create Task
Maniphest T156282

NWE section edit links initialisation crashes when DeleteSection gadget is enabled
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The gadget adds another section edit link "delete" which has no href (it triggers JS behaviour).

As reported here: https://www.mediawiki.org/wiki/Topic:Tiasdmiufk4vm8df

Details

SubjectRepoBranchLines +/-
Ignore section edit links when no action presentmediawiki/extensions/VisualEditormaster+7 -5
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jan 25 2017, 5:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2017, 5:27 PM
Mannivu subscribed.Jan 25 2017, 5:47 PM
Schnark subscribed.Jan 26 2017, 9:16 AM

In T111919: VE breaks on faked section edit links I was told not to use .mw-editsection for such stuff, but instead .mw-editsection-like.

Jdforrester-WMF closed this task as Resolved.Jan 26 2017, 2:06 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a project: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL