Page MenuHomePhabricator

Changing theme opens tab overview
Closed, InvalidPublic1 Estimated Story Points

Description

Steps to reproduce

  1. Open the app
  2. Open a page
  3. Open the theme settings dialog under the page overflow menu
  4. Toggle the theme (dark to light or light to dark)

Expected results

Theme changes

screenshot-2017-02-06-17-36-46-279716860.png (2×1 px, 922 KB)

Actual results

Theme changes but the tab overview is shown

screenshot-2017-02-06-17-36-37-281726639.png (2×1 px, 646 KB)

Environments observed

App version: 84ac60a
Android OS versions: API 25
Device model: Nexus 6P
Device language:English

Event Timeline

@Dbrant @Mholloway. please check out my fix in Gerrit for persisting theme changes but I noticed this second regression as well

I'm actually not seeing this, either at 84ac60a or current HEAD. Same device/version/language.

Yeesh, I swear this was happening but not this morning