Page MenuHomePhabricator

InvalidTitle not raised by getCategoryLinks
Closed, ResolvedPublic

Description

[[ https://travis-ci.org/wikimedia/pywikibot-core/jobs/201425625#L3953 | <tests.textlib_tests.TestTemplatesInCategory testMethod=test_templates> is failing ]]:

____________________ TestTemplatesInCategory.test_templates ____________________

self = <tests.textlib_tests.TestTemplatesInCategory testMethod=test_templates>

    def test_templates(self):

        """Test normal templates inside category links."""

        self.site = self.get_site()

        self.assertEqual(textlib.getCategoryLinks(

            '[[Category:{{P1|Foo}}]]', self.site, expand_text=True),

            [pywikibot.page.Category(self.site, 'Foo')])

        self.assertEqual(textlib.getCategoryLinks(

            '[[Category:{{P1|Foo}}|bar]]', self.site, expand_text=True),

            [pywikibot.page.Category(self.site, 'Foo', sortKey='bar')])

        self.assertEqual(textlib.getCategoryLinks(

            '[[Category:{{P1|{{P2|L33t|Foo}}}}|bar]]',

            self.site, expand_text=True),

            [pywikibot.page.Category(self.site, 'Foo', sortKey='bar')])

        self.assertEqual(textlib.getCategoryLinks(

            '[[Category:Foo{{!}}bar]]', self.site, expand_text=True),

            [pywikibot.page.Category(self.site, 'Foo', sortKey='bar')])

        self.assertEqual(textlib.getCategoryLinks(

            '[[Category:Foo{{!}}bar]][[Category:Wiki{{P2||pedia}}]]',

            self.site, expand_text=True),

            [pywikibot.page.Category(self.site, 'Foo', sortKey='bar'),

             pywikibot.page.Category(self.site, 'Wikipedia')])

        self.assertEqual(textlib.getCategoryLinks(

            '[[Category:Foo{{!}}and{{!}}bar]]', self.site, expand_text=True),

            [pywikibot.page.Category(self.site, 'Foo', sortKey='and|bar')])

        self.assertRaises(pywikibot.InvalidTitle, textlib.getCategoryLinks,

>                         '[[Category:nasty{{{!}}]]', self.site)

E       AssertionError: InvalidTitle not raised by getCategoryLinks

tests/textlib_tests.py:302: AssertionError

Event Timeline

Probably caused by {fb7f54b6b85fa548b94ff827cdd849d5586e4a46}

Change 337548 had a related patch set uploaded (by Dalba):
textlib_tests: Don't expect textlib.getCategoryLinks to raise InvalidTitle

https://gerrit.wikimedia.org/r/337548

Change 337548 merged by jenkins-bot:
textlib_tests: Don't expect textlib.getCategoryLinks to raise InvalidTitle

https://gerrit.wikimedia.org/r/337548