| • brion | |
| Feb 15 2017, 1:02 PM |
| F5641285: Screen Shot 2017-02-15 at 5.42.23 AM.png | |
| Feb 15 2017, 1:43 PM |
| F5640959: Screen Shot 2017-02-15 at 12.58.47 PM.png | |
| Feb 15 2017, 1:02 PM |
I'm traveling in London at the moment, so computer time is set to UK local time. Phabricator shows a box in the lower-left corner of every page telling me that my profile's timezone is different from my browser time:
The only option is "click to reconcile", but I want it to just dismiss the notification and keep using my home local time the way I can on Google Calendar etc.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Phabricator: add override for the browser time zone conflict message | operations/puppet | production | +3 -0 |
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Phabricator: add override for the browser time zone conflict message | repos/phabricator/deployment!6 | dannys712 | dannys712-wmf/stable-patch-89495 | wmf/stable |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | DannyS712 | T158177 Phabricator "reconcile timezone" dialog options are confusing | |||
| Duplicate | None | T331673 Remove unused(?) fixed_settings.yaml from Phabricator puppet config |
The expectation is that you'll have an option to "Ignore Conflict", like this:
If you select that option, the notification should vanish until you change timezones again (but you'll remain in your home timezone). Do you not see that option? I can't immediately reproduce this.
Aha, that's a rather confusing UI to me; I would expect to have a separate button or link that says "ignore conflict" rather than hiding it in a drop-down list of timezones I must search through and then having to click something that says "Change Timezone" when I want to *not* change timezone. :)
I also got confused numerous times by having to click a "Change Timezone" button in order to NOT change my timezone setting (as I had chosen to "Ignore Conflict").
Could someone please remind the nice folks at Phacility that "Ignore Conflict" should actually ignore timezone conflicts? That is, it should ALWAYS ignore the timezone conflicts, and not have to be repeatedly told to ignore the conflict over and over. "Repeatedly telling" ≠ "ignoring".
Current behavior:
That's broken. It's annoying. It's actually stupid behavior. All this nagging about timezones should not be happening, and it very especially should not be happening if your Phab settings are UTC.
Desired behavior:
If that's not available, then could we at least set appropriate user expectations by changing the label? It shouldn't say "Ignore Conflict" when the plan is to keep hassling the user. It could instead say "Temporarily ignore conflict, until the next time your browser time changes".
Wikimedia does not plan to maintain a downstream patch for this, so feel free to bring this up in upstream at https://discourse.phabricator-community.org/
Can we maintain a downstream patch that just changes the message shown to say that ignore conflict is one of the timezone options, to make it a bit easier to find?
Can we maintain a downstream patch that just changes the message shown to say that ignore conflict is one of the timezone options, to make it a bit easier to find?
Yes, translation.override could be used for that if wanted.
Change 718418 had a related patch set uploaded (by DannyS712; author: DannyS712):
[operations/puppet@production] Phabricator: add override for the browser time zone conflict message
If the default selected option could be changed to be the ignore option (I know that can't be changed in translation), the "Change Timezone" label on the button would be changed to "Confirm" and the "Click to reconcile" toast would say "Click to set your preferences", we'd pretty much be there?
Assuming the default selected option can't be changed, I suppose explaining it in text is the next best option.
Or maybe @Whatamidoing-WMF's suggestion isn't so bad either: can't you just nuke that toast?
In the patch, in addition to changing the popup text to explain how to ignore the conflict, I switched the yellow notification to explain that the popup that it opens can also be used to ignore the conflict.
It means make it so that it will never bother anyone ever again. Unfortunately I suspect it doesn't have a unique class or id:
` <div class="jx-notification-container"><div data-sigil=" jx-notification" class="jx-notification jx-notification-alert">Your browser timezone setting differs from the timezone setting in your profile, click to reconcile.</div></div>
Otherwise a single line of custom CSS could hide it without touching any of the involved code. If there is an internal configuration option to disable this toast, even better, but if not there's probably no way (that isn't ugly) to get rid of it completely without fiddling with the code.
dannys712 opened https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/6
Phabricator: add override for the browser time zone conflict message
Change 718418 abandoned by DannyS712:
[operations/puppet@production] Phabricator: add override for the browser time zone conflict message
Reason:
sent https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/6
brennen merged https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/6
Phabricator: add override for the browser time zone conflict message
This is deployed now locally on WIkimedia Phabricator (I just tested it by changing my timezone). Thanks for the patch!
I filed an upstream ticket at https://we.phorge.it/T15349