Page MenuHomePhabricator

[ia-upload] Don't allow conversion from JP2 if there isn't a
Closed, ResolvedPublic3 Story Points


Like this one (has DjVu and PDF, but no JP2):

This is recorded in the logs as LOG.CRITICAL: Zip file not found.

We should check for the existence of the zip file before allowing people to save the job to the queue. Or, better: we could look for other images such as and extract accordingly.

This probably only affects older IA items, because I think the modern system is to create a standard JP2 zip for everything.

Event Timeline

Restricted Application added a project: Internet-Archive. · View Herald TranscriptFeb 17 2017, 6:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwilson moved this task from Backlog to IA Upload on the Wikisource board.Feb 17 2017, 6:04 AM
Samwilson renamed this task from [ia-upload] Don't allow conversion from JP2 if there isn't a #28 to [ia-upload] Don't allow conversion from JP2 if there isn't a 20 2017, 6:53 AM
Samwilson triaged this task as Normal priority.
Samwilson updated the task description. (Show Details)
Samwilson edited projects, added IA Upload; removed Wikisource.May 25 2017, 11:28 AM
kaldari lowered the priority of this task from Normal to Low.Jun 13 2017, 11:54 PM
kaldari set the point value for this task to 3.

The error message pops out too in cases where file exists, but its prefix is different from IA ID.

Can the log message error be edited, and forced to tell precisely what is not found, t.i. printing the full name of searched file?


Yes, definitely can throw a better error, good idea.

Do you have an example of one where it's failing but does have a

Alex_brollo added a comment.EditedNov 3 2017, 7:51 AM

The large majority of them have a I found only one item (an old IA upload) that fails because there's a and a is lacking - I presume that in that case the problem could be solved by IA uploader/IA sysop simply deleting file into the item and deriving the item again.

Here the first IA item with LOG.CRITICAL: Zip file not found having a file: 026BarettiLaSceltaDelleLettereFamiliariSi032

As you can see from IA file list, IA ID is


while prefix is

Samwilson edited projects, added Community-Tech-Sprint; removed Community-Tech.
Samwilson closed this task as Resolved.Nov 29 2017, 2:12 AM

Merged and tested.

DannyH moved this task from Estimated to Archive on the Community-Tech board.Dec 19 2017, 1:14 AM