Page MenuHomePhabricator

After filtering applications, clicking to another page resets the filter
Closed, ResolvedPublic

Description

To reproduce, filter https://wikipedialibrary.wmflabs.org/applications/list/sent/ for Taylor & Francis, then click any of the page numbers at the bottom.

Event Timeline

Samwalton9-WMF raised the priority of this task from Medium to High.Apr 21 2017, 11:09 PM
Samwalton9-WMF added a subscriber: jsn.sherman.

@jsn.sherman Could you take a look at this this week? As a functionality issue we should probably sort it sooner rather than later.

so there are a few options ranging from quick and dirty to slow and excellent:

  1. disable pagination on these views
  2. convert pagination elements from links to forms
  3. rework the way the context is getting passed around in the application views

Disabling pagination on filtered views is probably the way forward for now.

Quick fix pushed, please verify that applications view is less unhappy @Samwalton9.

Samwalton9-WMF lowered the priority of this task from High to Low.Apr 25 2017, 9:25 AM

Well I can definitely see all the applications now!

Re-prioritising this for a more thorough fix some time in the future.

Samwalton9-WMF raised the priority of this task from Low to Medium.Jul 4 2017, 6:24 PM

Needs a fuller fix before migration.

Just needs something to reduce or sort the view of applications, not necessarily pagination.

Pagination + filtering up on staging. Since there are a large number of apps imported there, it's pretty representative of what the experience will be.

Failed to note that this has been pushed to the live site.

This problem seems to have returned.

To reproduce, filter https://wikipedialibrary.wmflabs.org/applications/list/sent/ for Taylor & Francis, then click any of the page numbers at the bottom.

Samwalton9-WMF raised the priority of this task from Medium to High.Jul 24 2017, 9:29 AM
Samwalton9-WMF moved this task from Doing to Major Bugs on the Library-Card-Platform board.

I think I've spotted the issue. When clicking to another page the URL is constructed as

?page=2&Partner=Taylor%20%26%20Francis

It looks like the page number takes priority (opening page 2 of all applications), and then the filter is ignored.

This looks like an encoding issue. Should be straightforward to resolve.