Currently the content on wikipedia.org is hidden with javascript until a script fetches translations and replaces the text. This could lead to a situation where, if the script breaks, the content remains invisible.
A timeout should be set near the top of the page that added the classname jsl10n-visible to the HTML element so that the content is forced to be visible after a certain amount of time, regardless of whether the translations are ready.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Setting a timeout to force display of page content | wikimedia/portals | master | +37 -11 |
Sounds good to me.
Side note: the code can be put at the bottom of the page, it's just there as a worst-case fallback.
Change 339376 had a related patch set uploaded (by Jdrewniak):
Setting a timeout to force display of page content
A user has mailed dns-admin@ and said:
Your JavaScript is slowing down your page time which leads to less user friendly module At https://www.wikipedia.org/portal/wikipedia.org/assets/js/index-d1cc91a7f4.js I am one of your user at Wikipedia Username="Trish1996"
@Dzahn we monitor the performance of the wikipedia portal carefully here:
https://grafana.wikimedia.org/dashboard/db/webpagetest-portals?from=1458474417000&to=1490010417359
From all our metrics, the performance of the page has actually improved over the past year.
Change 339376 merged by jenkins-bot:
[wikimedia/portals] Setting a timeout to force display of page content