Page MenuHomePhabricator

Use ResourceLoaderImageModule for secondary link icons
Closed, ResolvedPublic

Description

Right now, secondary link icons are loaded using modules/styles/mw.echo.icons.less, which contains manually written rules like:

.oo-ui-icon-thanks {
        .background-image('../icons/thanks-ltr.svg');
}

Since these are normal OOUI icons (24x24px and everything), it would be nicer and relatively easy to put them into a ResourceLoaderImageModule similar to the emailicons module, by generalizing ResourceLoaderEchoImageModule. That would also allow extensions to define their own secondary link icons, which we want to do in Thanks: T151768: Move Thanks icons to Thanks repo

Event Timeline

Catrope created this task.Mar 2 2017, 12:54 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 2 2017, 12:54 AM

Change 340689 had a related patch set uploaded (by MtDu):
[mediawiki/extensions/Echo] Support loading of secondary icons in RLEIM module

https://gerrit.wikimedia.org/r/340689

Change 340689 merged by MtDu:
[mediawiki/extensions/Echo] Support loading of secondary icons in RLEIM module

https://gerrit.wikimedia.org/r/340689

Catrope closed this task as Resolved.Mar 2 2017, 6:01 AM