Page MenuHomePhabricator
Create Task
Maniphest T149352

Echo Notifications Thank You uses outdated PNG icon instead of SVG
Closed, ResolvedPublic
Actions

Description

Echo's Notification Thank You items use an outdated PNG icon instead of an SVG. That's suboptimal for two reasons:

  1. Doesn't provide best experience on HiDPI screens
  2. Isn't aligned with the overhauled color palette at M82

Details

SubjectRepoBranchLines +/-
Replaced thanks-ltr/rtl (secondary) icons with larger thanks-green-ltr/rtl (main) iconsmediawiki/extensions/Thanksmaster+10 -10
Use SVG for Thanks notification icon instead of PNGmediawiki/extensions/Echomaster+14 -0
Replaced PNG icon with SVG icons for Thanks notificationsmediawiki/extensions/Thanksmaster+12 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Oct 27 2016, 7:09 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 27 2016, 7:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Volker_E mentioned this in T147365: Make Echo follow overhauled color palette.Oct 27 2016, 7:10 PM
Pginer-WMF added a comment.Oct 28 2016, 10:05 AM

Here it is a SVG-based version in case it is useful:

Volker_E added a comment.Oct 28 2016, 5:57 PM

That has already been in the repo https://phabricator.wikimedia.org/diffusion/ECHO/browse/master/modules/icons/thanks-ltr.svg (and its companion -rtl; without the positive/green fill color though). It's just not in use yet.

Catrope added a comment.Nov 8 2016, 6:50 PM

This could be because the Thanks notification isn't in the Echo extension, but in the Thanks extension.

Catrope added a comment.Nov 11 2016, 12:33 AM

I found out why: thanks.svg in Echo is a (24x24px) secondary link icon, whereas the (30x30px) notification icon for thanks notifications is ThankYou.png in the Thanks extension. I'll fix this.

gerritbot subscribed.Nov 11 2016, 1:45 AM

Change 320947 had a related patch set uploaded (by Catrope):
Use SVG for Thanks notification icon instead of PNG

https://gerrit.wikimedia.org/r/320947

gerritbot added a project: Patch-For-Review.Nov 11 2016, 1:45 AM

Change 320948 had a related patch set uploaded (by Catrope):
Delete PNG icon for Thanks notifications

https://gerrit.wikimedia.org/r/320948

Volker_E moved this task from Backlog to Doing… on the UI-Standardization-Kanban board.Nov 16 2016, 6:52 PM
Catrope mentioned this in T151768: Move Thanks icons to Thanks repo.Nov 28 2016, 4:22 PM
Catrope edited projects, added Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016); removed Collaboration-Team-Triage.Nov 29 2016, 6:42 PM
Catrope moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.
Volker_E reassigned this task from Volker_E to MtDu.Dec 22 2016, 5:03 PM
Volker_E added a subtask: T151768: Move Thanks icons to Thanks repo.
MtDu closed this task as Resolved.Dec 23 2016, 1:47 PM

Patch has been merged. Sorry for the delay!
Thanks!

gerritbot added a comment.Dec 23 2016, 1:49 PM

Change 320948 merged by jenkins-bot:
Replaced PNG icon with SVG icons for Thanks notifications

https://gerrit.wikimedia.org/r/320948

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 23 2016, 2:00 PM
Volker_E reopened this task as Open.Dec 31 2016, 3:28 AM

Re-opening as patch set 320947 is still around.

gerritbot added a comment.Dec 31 2016, 3:52 AM

Change 329729 had a related patch set uploaded (by MtDu):
Replaced thanks-ltr/rtl (secondary) icons with larger thanks-green-ltr/rtl (main) icons

https://gerrit.wikimedia.org/r/329729

gerritbot added a comment.Dec 31 2016, 3:53 AM

Change 320947 abandoned by Catrope:
Use SVG for Thanks notification icon instead of PNG

https://gerrit.wikimedia.org/r/320947

Volker_E closed this task as Resolved.Dec 31 2016, 4:01 AM
Volker_E triaged this task as Medium priority.
Volker_E removed a project: Patch-For-Review.
MtDu added a comment.Dec 31 2016, 4:01 AM

Patchset here has been merged. https://gerrit.wikimedia.org/r/#/c/329729/ Hence closing as resolved.
Thanks!

gerritbot added a comment.Dec 31 2016, 4:03 AM

Change 329729 merged by jenkins-bot:
Replaced thanks-ltr/rtl (secondary) icons with larger thanks-green-ltr/rtl (main) icons

https://gerrit.wikimedia.org/r/329729

Volker_E moved this task from Doing… to Review on the UI-Standardization-Kanban board.Feb 14 2017, 5:06 AM
Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.
Catrope closed subtask T151768: Move Thanks icons to Thanks repo as Resolved.Mar 2 2017, 12:41 AM
Catrope reopened subtask T151768: Move Thanks icons to Thanks repo as Open.Mar 2 2017, 12:47 AM
Catrope closed subtask T151768: Move Thanks icons to Thanks repo as Resolved.Jul 3 2018, 6:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL