Page MenuHomePhabricator

Special:RecentChangesLinked page does not have "No changes during the given period matching these criteria."
Closed, ResolvedPublic

Description

The issue is present in testwiki wmf.18

  1. Type or paste 'Special:RecentChangesLinked' into the Search box and got to the page.
  1. Special:RecentChangesLinked page with filters will not display "No changes during the given period matching these criteria." for filter combinations that do not return results.

Screen Shot 2017-03-14 at 4.54.53 PM.png (543×871 px, 81 KB)

Event Timeline

I see the "no results" message on Special:RelatedChanges. Could you elaborate on what you did to end up with no results and no message?

Screen Shot 2017-03-20 at 10.43.43.png (600×1 px, 120 KB)

@SBisson At some point I saw the "no results" message on Special:RecenChangesLinked in betalabs. It intermittently was present and non-present (did not have a chance to investigate it then). Now, the 'no results' message is not present - checked on plwiki, ptwiki, enwiki, and betalabs. I added some details to the description - just to make clear how I navigate to Special:RecenChangesLinked.

If you disable the RC filters beta feature, you'll see that Special:RecentChangesLinked never displays the "no results" message. It's just blank when there is no results.

However, RC filters adds it explicitly when you change filters and it applies.

I would propose changing Special:RecentChangesLinked to add the "no results" message on the server to make it more similar to Special:RC.

Change 345394 had a related patch set uploaded (by Sbisson):
[mediawiki/core@master] Special:RecentChangesLinked show "no results" message

https://gerrit.wikimedia.org/r/345394

Change 345394 merged by jenkins-bot:
[mediawiki/core@master] Special:RecentChangesLinked show "no results" message

https://gerrit.wikimedia.org/r/345394

Checked the fix in betalabs. The message is displayed (conflicting states have the specific message displayed).

Screen Shot 2017-03-29 at 4.21.33 PM.png (674×1 px, 132 KB)

Screen Shot 2017-03-29 at 4.21.56 PM.png (675×1 px, 135 KB)

QA Recommedation: Resolve