Having two checkboxes "Ignore" and "Import and ask updates" for each message is very confusing: in particular, one wonders what happens if both are selected. How can a message be both ignored and imported?
Description
Description
Details
Details
Event Timeline
Comment Actions
Sounds like a radio button is appropriate to use here when there are multiple options.
Comment Actions
$label = $this->msg( 'translate-manage-action-ignore' )->text();
$actions = Xml::checkLabel( $label, "i/$id", "i/$id" );
$limit--;
if ( $group->getSourceLanguage() === $code ) {
$label = $this->msg( 'translate-manage-action-fuzzy' )->text();
$actions .= ' ' . Xml::checkLabel( $label, "f/$id", "f/$id", true );
$limit--;
}Comment Actions
I'm trying to reproduce this, but I can' t.
My http://127.0.0.1:8080/wiki/Special:ManageMessageGroups page says:
There are no changes to process.
Not sure where I need to make the changes. I've read this:
https://www.mediawiki.org/wiki/Help:Extension:Translate/Group_configuration
and a bunch of other pages like:
https://www.mediawiki.org/wiki/Help:Extension:Translate/Translation_example
Comment Actions
I didn't get lucky with this one, I can't get the configuration work. I leave it for now so that it becomes open in case someone elase wants to work on it.
Comment Actions
Change 505385 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Replace checkbox with radio buttons on Special:ManageMessageGroups
Comment Actions
Replaced the check-boxes with the radio buttons to make the UI more aligned with the actual behavior. Also added another option "Import" which is displayed when there is a change in a non-source translation.
Also moved the ignore button to the end as it made more sense to have the default selected options shown first.
Comment Actions
Change 345596 abandoned by Abijeet Patro:
Radio button for ignore vs. fuzzy on Special:ManageMessageGroups
Reason:
Abandoned in favor of I9c7e7e18ed4996d36e48253a66c5789afe4f9e86
Comment Actions
Added the import button for source language also. This will import the changes, without marking translations in other language as fuzzy.
Tweaked the CSS as per discussion with Niklas, and tested across themes. Here are a few screenshots,
Comment Actions
Change 505385 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Replace checkbox with radio buttons on Special:ManageMessageGroups
Comment Actions
Have been using this updated UI on Translatewiki.net for a few days now. Changes have been working as expected.
Today, also used the UI to ignore a change.
