Page MenuHomePhabricator

RC ORES filters do not force a changed state to 'r': it displayed black until page reloaded
Closed, ResolvedPublic

Description

'r' indication 'may be damaging' edit is displayed black in the Legend where there are no RC records indicated as damaging present in the viewport.
'r' turned red if according to the settings for RC changes, the 'may be damaging' edits appear on the RC page.

Example:

  1. In production, on ORES enabled wiki (enwiki, for example), go to Preferences - Recent changes and change in 'Display options' , 'Days to show in recent changes' to 1 and 'Number of edits to show in recent changes, page histories, and in logs, by default' also to 1 (so to increase the likelihood that ORES scored as damaging edits won't get into your restricted selection).
  1. click on 'Recent changes' - most likely you'll see a record that is not scored as 'may be damaging' by ORES - and 'r' in the Legend, will be black e.g.

Screen Shot 2017-03-21 at 4.06.09 PM.png (544×1 px, 147 KB)

  1. Now, select 50, 100 etc changes and select 3, 7, or 30 days - if ORES scored records will be returned, the 'r' will turn red.

However, if the same steps are repeated for RC filters, there will be a state - in #3 the 'r' will not turn red, instead, all 'r' - in the Legend and beside records will be displayed as black.

Screen Shot 2017-03-21 at 4.16.49 PM.png (581×1 px, 208 KB)

Reload the page - all 'r' will turned red:
Screen Shot 2017-03-21 at 8.56.21 AM.png (408×1 px, 111 KB)

Event Timeline

Etonkovidova renamed this task from RC ORES filter do not force a changed state to 'r': it displayed black until page reloaded to RC ORES filters do not force a changed state to 'r': it displayed black until page reloaded .Mar 22 2017, 4:29 PM

The "r" has been change to be red when the oresHighlight preference is on.

Is this ticket still relevant?

@SBisson yes, it seems the bug is not relevant anymore.

@jmatazzoni - please confirm that the below is desirable behavior.

  • 'r' is never red on RC page - even after disabling 'New filters for edit review' beta feature.
  • 'Highlight probably damaging edits on Watchlist and Contributions (using ORES)' when ON will display 'r' as red on Watchlist and Contribution.

QA Recommendation: Product should weigh in

  • 'r' is never red on RC page - even after disabling 'New filters for edit review' beta feature.
  • 'Highlight probably damaging edits on Watchlist and Contributions (using ORES)' when ON will display 'r' as red on Watchlist and Contribution.

QA Recommendation: Product should weigh in

I think this is OK, and that the ticket is no longer relevant. A newer ticket, T162831, specifies

Functional change: always display the "r" for "needs review" in black on all pages
That's on Recent Change, Watchlist and Contributions. Always black, no red.