Page MenuHomePhabricator
Create Task
Maniphest T161213

Invalid hint about <br> tag in Translate extension
Closed, ResolvedPublic
Actions

Description

Translate extension interface incorrectly tries to push user to write <br /> instead of <br>, preventing them from editing (at least in TUX). Even if developers of Translate extension prefer the stricter version in line with XHTML, MediaWiki doesn’t differentiate between both, so it shouldn’t be a breaking bug for the extension. W3C specification doesn’t require trailing slash for void elements: https://www.w3.org/TR/html5/syntax.html#start-tags

Then, if the element is one of the void elements, or if the element is a foreign element, then there may be a single "/" (U+002F) character. This character has no effect on void elements, but on foreign elements it marks the start tag as self-closing.

Text: Please replace the following tag with correct ones: <br> → <br />
Screenshot:

c8VdyVB.png (481×673 px, 36 KB)

Point of reference: T134423.

Details

SubjectRepoBranchLines +/-
Remove Xhtml check for translatable pages and extensionsmediawiki/extensions/Translatemaster+0 -6
Remove xhtml check from mediawiki core and extensiontranslatewikimaster+0 -3
Customize query in gerrit

Related Objects

Event Timeline

stjn created this task.Mar 23 2017, 1:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2017, 1:15 PM
stjn renamed this task from Invalid hint about <br> tag to Invalid hint about <br> tag in Translate extension.Mar 23 2017, 1:16 PM
Nikerabbit subscribed.Mar 24 2017, 7:02 AM

Yes it seems the br rule is no longer relevant, but the issue appears because you are adding <br> where one does not exist in the source text.

Nemo_bis closed this task as Invalid.Mar 24 2017, 7:40 AM
Nemo_bis subscribed.

There seem to be two real issues here:

  • you are adding markup which the source text doesn't have (why are you? as a Meta-Wiki translation admin I suggest you to report any problems you have);
  • the message about unexpected markup is confusing.

However I don't think that suggesting to prefer <br /> over <br> is incorrect as of now; on many wikis users hate <br> so much that there are even bots to replace them (as much as I dislike such bots).

Nikerabbit reopened this task as Open.Mar 24 2017, 7:43 AM
Nemo_bis unsubscribed.Mar 24 2017, 7:47 AM
Nemo_bis updated the task description. (Show Details)Mar 24 2017, 7:52 AM
stjn added a comment.Mar 24 2017, 10:26 AM
In T161213#3127480, @Nikerabbit wrote:

Yes it seems the br rule is no longer relevant, but the issue appears because you are adding <br> where one does not exist in the source text.

This is not the case, since there’s no hint about adding <br />, only <br>. <br /> isn’t in the source text either, but no hints etc. appear for it: https://i.imgur.com/LWiZFgk.png (sorry about not using file uploads).

I agree that there’s no consensus over which variant is correct (although HTML spec is clear on that part), but Translate extension then shouldn’t force users to any variant either. As I said above, right now you can’t even use normal tag (<br>) in the message, it instantly appears as incorrect in the final text: https://i.imgur.com/rgTW5iC.png

Jack_who_built_the_house subscribed.Mar 24 2017, 10:35 AM
Jack_who_built_the_house added a subscriber: Perhelion.EditedMar 24 2017, 11:43 AM

I agree, the hint "Please replace the following tag with correct ones" (bold is mine) is irrelevant, since it is just untrue. <br> is not just correct, but is a preferred version in all major HTML style guides that I know of: Google, jQuery, GitHub. Last XHTML specification recommended for use was updated back in 2010, it is pretty much an outdated standard.

gerritbot subscribed.Mar 29 2017, 12:47 PM

Change 345318 had a related patch set uploaded (by Nikerabbit):
[mediawiki/extensions/Translate@master] Remove Xhtml check for translatable pages and extensions

https://gerrit.wikimedia.org/r/345318

gerritbot added a project: Patch-For-Review.Mar 29 2017, 12:47 PM
gerritbot added a comment.Mar 29 2017, 12:49 PM

Change 345319 had a related patch set uploaded (by Nikerabbit):
[translatewiki@master] Remove xhtml check from mediawiki core and extension

https://gerrit.wikimedia.org/r/345319

Nikerabbit claimed this task.Mar 29 2017, 12:50 PM
Nikerabbit triaged this task as Low priority.
gerritbot added a comment.Apr 13 2017, 2:16 PM

Change 345319 merged by jenkins-bot:
[translatewiki@master] Remove xhtml check from mediawiki core and extension

https://gerrit.wikimedia.org/r/345319

gerritbot added a comment.Apr 15 2017, 7:34 PM

Change 345318 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove Xhtml check for translatable pages and extensions

https://gerrit.wikimedia.org/r/345318

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 15 2017, 8:00 PM
Nikerabbit closed this task as Resolved.Apr 16 2017, 3:40 PM
Nikerabbit removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits