Page MenuHomePhabricator

Replace the check for $wgVisualEditorSupportedSkins with a check for something in the skin itself
Closed, ResolvedPublic8 Estimated Story Points


Essentially, let the skin developers change the skin to meet the requirements and be done with it. Don't make the users also have to edit localsettings.php after that fact. That's just silly.


  • Do a check for all the elements we expect a skin to provide (since it should at least be functional at the point)
  • Add a hook for the skin to register itself as definitely compatible (basically like the current approach, but moves the responsibility from the skin user to the skin developer)
  • ...

Event Timeline

Jdforrester-WMF set the point value for this task to 8.

Change 345207 had a related patch set uploaded (by Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Replace $wgVisualEditorSupportedSkins with a check for required elements

Change 345207 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Replace $wgVisualEditorSupportedSkins with a check for required elements

VisualEditor will now check for the presence of:

  • '#content' to attach our interface (toolbar etc.)
  • '#mw-content-text' to replace with the editing surface
  • '#ca-edit' to start up the editor

And try to initialize if these are present.

This is documented at