Page MenuHomePhabricator

Disabling a ve.ce.DocumentNode leaves descendant ActiveNodes enabled
Closed, ResolvedPublic1 Story Points

Description

Steps to reproduce:

  1. In VE standalone, edit <section>foo</section>bar
  2. In the console, do: ve.init.target.surface.view.documentView.documentNode.disable()

Observed behaviour: 'foo' is editable (but 'bar' is not)
Expected behaviour: 'foo' is not editable (and neither is 'bar')

This is because ce=false on the document node is overridden by ce=true on the descendant ActiveNode .

Event Timeline

dchan created this task.Apr 1 2017, 6:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2017, 6:11 AM

Change 345955 had a related patch set uploaded (by Divec):
[VisualEditor/VisualEditor@master] When setting ce=true/false on a ve.ce.DocumentNode, change descendants too

https://gerrit.wikimedia.org/r/345955

Jdforrester-WMF triaged this task as Normal priority.Apr 1 2017, 3:19 PM
Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.

...and table cells.

Change 345955 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one

https://gerrit.wikimedia.org/r/345955

Change 348497 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (fc46ed86f)

https://gerrit.wikimedia.org/r/348497

Change 348497 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (fc46ed86f)

https://gerrit.wikimedia.org/r/348497

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 17 2017, 9:37 PM