Page MenuHomePhabricator
Create Task
Maniphest T161944

Disabling a ve.ce.DocumentNode leaves descendant ActiveNodes enabled
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. In VE standalone, edit <section>foo</section>bar
  2. In the console, do: ve.init.target.surface.view.documentView.documentNode.disable()

Observed behaviour: 'foo' is editable (but 'bar' is not)
Expected behaviour: 'foo' is not editable (and neither is 'bar')

This is because ce=false on the document node is overridden by ce=true on the descendant ActiveNode .

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (fc46ed86f)mediawiki/extensions/VisualEditormaster+5 -1
ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer oneVisualEditor/VisualEditormaster+139 -34
Customize query in gerrit

Related Objects

Event Timeline

dchan created this task.Apr 1 2017, 6:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2017, 6:11 AM
gerritbot subscribed.Apr 1 2017, 6:12 AM

Change 345955 had a related patch set uploaded (by Divec):
[VisualEditor/VisualEditor@master] When setting ce=true/false on a ve.ce.DocumentNode, change descendants too

https://gerrit.wikimedia.org/r/345955

gerritbot added a project: Patch-For-Review.Apr 1 2017, 6:12 AM
Jdforrester-WMF triaged this task as Medium priority.Apr 1 2017, 3:19 PM
Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Esanders subscribed.Apr 3 2017, 3:05 PM

...and table cells.

gerritbot added a comment.Apr 13 2017, 11:58 AM

Change 345955 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one

https://gerrit.wikimedia.org/r/345955

gerritbot added a comment.Apr 17 2017, 5:49 PM

Change 348497 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (fc46ed86f)

https://gerrit.wikimedia.org/r/348497

gerritbot added a comment.Apr 17 2017, 8:12 PM

Change 348497 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (fc46ed86f)

https://gerrit.wikimedia.org/r/348497

Jdforrester-WMF closed this task as Resolved.Apr 17 2017, 9:37 PM
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)); removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 17 2017, 9:37 PM
Ryasmeen moved this task from To be Verified to Non verifiable/Task on the User-Ryasmeen board.Apr 24 2017, 10:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits