Page MenuHomePhabricator

Use standardised ajax loader and refresh icon in ConfirmEdit
Open, LowPublic1 Estimated Story Points

Description

The fancycaptcha-reload-loading class adds an ajax spinner and .fancycaptcha-reload class to add a reload icon.
The icon is inconsistent with the mobile Minerva skin.

Can these use OOjs UI icons instead or at the very least make use of some standard mediawiki UI icon?

Code: https://github.com/wikimedia/mediawiki-extensions-ConfirmEdit/blob/master/FancyCaptcha/resources/images/refresh.svg

Event Timeline

Jdlrobson renamed this task from Use standardised ajax loader and refresh icon to Use standardised ajax loader and refresh icon in ConfirmEdit.Apr 4 2017, 9:03 PM
Jdlrobson added a project: VisualEditor.
Jdlrobson moved this task from Incoming to 2014-15 Q4 on the Web-Team-Backlog board.

What images do you propose? (Sorry, probably I just haven't seen refresh images in OOJs UI?)

I could also imagine, that an intermediate progressbar could be used for a refresh indication, instead of a loading circle?

In VE/NWE we use dialog pending state rather than a rotating/whatever icon, for consistency (and don't load fancycaptcha-reload-loading at all). Once we switch mobile front-end over to this it'll be solved, but ahead of that we could migrate that code to do an indeterminate progress bar if it's urgent.

Jdforrester-WMF moved this task from To Triage to Epics on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.

We've recently added the 'reload' icon to OOjs UI (see https://doc.wikimedia.org/oojs-ui/master/demos/?page=icons ) for a different purpose, which might be used here.