Page MenuHomePhabricator
Create Task
Maniphest T162455

Selenium tests for Math
Closed, ResolvedPublic
Actions

Description

Done

✅ Selenium tests for Math, 346982, mediawiki/extensions/Math
💀 Run Selenium tests for Math, 433983, integration/config
✅ Run qunit-selenium job for Math in experimental pipeline, 434276, integration/config
✅ Delete Selenium tests in Ruby, 434936, mediawiki/extensions/Math
✅ Do not run mwgate-rake-docker job for Math, 434950, integration/config
✅ Run daily job running Math Selenium tests targeting beta cluster, 435990, integration/config
✅ T195206: mediawiki-core-qunit-selenium-jessie tests for math broken
✅ Run Selenium tests for Math, 440325, integration/config

Details

SubjectRepoBranchLines +/-
Run Selenium tests for Mathintegration/configmaster+3 -1
Run daily job running Math Selenium tests targeting beta clusterintegration/configmaster+8 -8
Delete Selenium tests in Rubymediawiki/extensions/Mathmaster+0 -253
Do not run mwgate-rake-docker job for Mathintegration/configmaster+0 -1
Selenium tests for Mathmediawiki/extensions/Mathmaster+159 -2
Run Selenium tests for Mathintegration/configmaster+3 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Apr 7 2017, 1:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2017, 1:00 PM
gerritbot subscribed.Apr 7 2017, 1:40 PM

Change 346982 had a related patch set uploaded (by Zfilipin):
[mediawiki/extensions/Math@master] WIP WebdriverIO tests for Math

https://gerrit.wikimedia.org/r/346982

gerritbot added a project: Patch-For-Review.Apr 7 2017, 1:40 PM
Physikerwelt added a comment.Apr 8 2017, 10:30 AM

@zeljkofilipin thanks for looking into that. Please let me know if there is something that I can test.

zeljkofilipin added a comment.Apr 10 2017, 3:28 PM

@Physikerwelt: I have updated the patch in gerrit.

zeljkofilipin removed zeljkofilipin as the assignee of this task.Apr 10 2017, 3:28 PM
zeljkofilipin changed the task status from Open to Stalled.May 25 2017, 4:11 PM
zeljkofilipin added a project: Browser-Tests.
zeljkofilipin removed a project: User-zeljkofilipin.
gerritbot added a comment.May 25 2017, 4:12 PM

Change 346982 abandoned by Zfilipin:
WIP WebdriverIO tests for Math

Reason:
no activity

https://gerrit.wikimedia.org/r/346982

gerritbot added a comment.Jun 1 2017, 10:29 AM

Change 346982 restored by Zfilipin:
WIP WebdriverIO tests for Math

https://gerrit.wikimedia.org/r/346982

zeljkofilipin changed the task status from Stalled to Open.Jun 1 2017, 10:36 AM
zeljkofilipin claimed this task.
zeljkofilipin added a project: User-zeljkofilipin.
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJun 1 2017, 10:36 AM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Jun 9 2017, 1:14 PM
zeljkofilipin moved this task from Backlog to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.
hashar subscribed.Jul 6 2017, 9:51 AM

The webdriver.io patch on https://gerrit.wikimedia.org/r/#/c/346982/ is a port of the ruby browser test. It basically:

  • edit a page
  • enter a formula
  • assert some image got generated

The ruby version runs daily against beta with both firefox and chrome. That is a good smoke test to ensure Math works fine on the beta cluster. For proposed patches, I don't think it brings any value, the PHPUnit integration tests should be covering it already.

On patchset proposal, that test should not be run. When we come to migrate the job selenium-Math from ruby to javascript, we would to run it though. So we need in Webdriver.io a system similar to the cucumber tag. Zeljko mentioned suites for that.

zeljkofilipin changed the task status from Open to Stalled.Jul 27 2017, 2:07 PM
zeljkofilipin mentioned this in T139740: Port Selenium tests from Ruby to Node.js.
zeljkofilipin added a comment.Aug 24 2017, 4:29 PM

To make it explicit, we did not invest time in updating CI so the example test runs fine there because the repository owner(s) do not have time and/or interest in writing Selenium tests (as far as we can see).

gerritbot added a comment.Sep 28 2017, 11:16 AM

Change 346982 abandoned by Zfilipin:
WIP WebdriverIO tests for Math

Reason:
No activity in months.

https://gerrit.wikimedia.org/r/346982

zeljkofilipin moved this task from Backlog 🪒 to Watching 📺 on the User-zeljkofilipin board.Oct 11 2017, 2:56 PM
zeljkofilipin removed projects: User-zeljkofilipin, Browser-Tests, Patch-For-Review, JavaScript.Nov 10 2017, 3:27 PM
zeljkofilipin added a comment.Nov 14 2017, 2:42 PM

@Physikerwelt let me know if you need help. I am available for pairing and/or code review. Documentation is available: Selenium/Node.js, Selenium/Node.js/Write...

zeljkofilipin added a project: VisualEditor.Nov 14 2017, 2:55 PM
greg removed a project: Release-Engineering-Team (Kanban).Apr 23 2018, 4:29 PM
greg subscribed.
In T162455#3759103, @zeljkofilipin wrote:

@Physikerwelt let me know if you need help. I am available for pairing and/or code review. Documentation is available: Selenium/Node.js, Selenium/Node.js/Write...

Let us know if you need any more help.

zeljkofilipin changed the task status from Stalled to Open.May 19 2018, 11:13 AM
zeljkofilipin assigned this task to Physikerwelt.
zeljkofilipin added projects: User-zeljkofilipin, Wikimedia-Hackathon-2018.
zeljkofilipin moved this task from Watching 📺 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Backlog to Sprints on the Wikimedia-Hackathon-2018 board.
gerritbot added a comment.May 19 2018, 11:15 AM

Change 346982 restored by Zfilipin:
WIP WebdriverIO tests for Math

https://gerrit.wikimedia.org/r/346982

zeljkofilipin renamed this task from WebdriverIO tests for Math to Selenium tests for Math.May 19 2018, 11:16 AM
gerritbot added a comment.May 19 2018, 1:22 PM

Change 433983 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Run Selenium tests for Math

https://gerrit.wikimedia.org/r/433983

gerritbot added a project: Patch-For-Review.May 19 2018, 1:22 PM
gerritbot added a comment.May 19 2018, 2:52 PM

Change 433983 merged by jenkins-bot:
[integration/config@master] Run Selenium tests for Math

https://gerrit.wikimedia.org/r/433983

• Deskana moved this task from To Triage to External and Administrivia on the VisualEditor board.May 23 2018, 12:45 PM
gerritbot added a comment.May 24 2018, 3:27 PM

Change 434936 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/Math@master] Delete Selenium tests in Ruby

https://gerrit.wikimedia.org/r/434936

gerritbot added a comment.May 24 2018, 4:14 PM

Change 346982 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Selenium tests for Math

https://gerrit.wikimedia.org/r/346982

gerritbot added a comment.May 24 2018, 4:20 PM

Change 434950 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Do not run mwgate-rake-docker job for Math

https://gerrit.wikimedia.org/r/434950

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 24 2018, 5:00 PM
gerritbot added a comment.May 25 2018, 11:05 PM

Change 434950 merged by jenkins-bot:
[integration/config@master] Do not run mwgate-rake-docker job for Math

https://gerrit.wikimedia.org/r/434950

gerritbot added a comment.May 29 2018, 11:28 AM

Change 434936 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Delete Selenium tests in Ruby

https://gerrit.wikimedia.org/r/434936

gerritbot added a comment.May 29 2018, 12:08 PM

Change 435990 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Run daily job running Math Selenium tests targeting beta cluster

https://gerrit.wikimedia.org/r/435990

gerritbot added a comment.May 29 2018, 4:51 PM

Change 435990 merged by jenkins-bot:
[integration/config@master] Run daily job running Math Selenium tests targeting beta cluster

https://gerrit.wikimedia.org/r/435990

zeljkofilipin removed a project: Patch-For-Review.May 29 2018, 4:54 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)May 29 2018, 4:57 PM
zeljkofilipin updated the task description. (Show Details)May 29 2018, 5:15 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)May 29 2018, 5:18 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)May 29 2018, 5:21 PM
zeljkofilipin updated the task description. (Show Details)
gerritbot added a comment.Jun 14 2018, 11:07 AM

Change 440325 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Revert "Run qunit-selenium job for Math in experimental pipeline"

https://gerrit.wikimedia.org/r/440325

gerritbot added a project: Patch-For-Review.Jun 14 2018, 11:07 AM
zeljkofilipin updated the task description. (Show Details)Jun 14 2018, 11:10 AM
zeljkofilipin updated the task description. (Show Details)Jun 14 2018, 11:12 AM
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 11:24 AM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 11:28 AM
gerritbot added a comment.Jun 15 2018, 12:14 PM

Change 440325 merged by jenkins-bot:
[integration/config@master] Run Selenium tests for Math

https://gerrit.wikimedia.org/r/440325

zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 12:34 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin closed this task as Resolved.Jun 15 2018, 12:37 PM

I think this is resolved. Please reopen if there is anything left to do. I will work on T161697: Run Selenium tests using Firefox soon, but I don't think it is blocking this task.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 15 2018, 12:37 PM
zeljkofilipin added a parent task: T190994: Q4 Selenium framework improvements.Jun 15 2018, 12:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits