Page MenuHomePhabricator
Create Task
Maniphest T162509

script_tests.TestScriptHelp and script_tests.TestScriptSimulate are failing with "AssertionError: u'deprecated' unexpectedly found"
Closed, ResolvedPublic
Actions

Description

https://travis-ci.org/wikimedia/pywikibot-core/jobs/219760238

There are 51 errors in TestScriptSimulate and 76 errors in TestScriptHelp. The errors are mostly the same.

======================================================================

FAIL: test_wikisourcetext (tests.script_tests.TestScriptSimulate)

Test running wikisourcetext -simulate.

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/wikimedia/pywikibot-core/tests/script_tests.py", line 319, in testScript

    self.assertNotIn('deprecated', result['stderr'].lower())

AssertionError: u'deprecated' unexpectedly found in u'/home/travis/build/wikimedia/pywikibot-core/pywikibot/__init__.py:238: deprecationwarning: pywikibot.deprecate_arg is deprecated; use pywikibot.tools.deprecate_arg instead.\n  @deprecate_arg(\'entity\', \'globe_item\')\nerror: missing parameter(s) "-index"\nuse -help for further information.\n'

A recent usage of pywikibot.deprecate_arg has been in e54e5849dc3062bdcbe1cfceb15350a24e7875a7 (line 238).

Details

SubjectRepoBranchLines +/-
pywikibot/__init__.py: Do not use `deprecate_arg`pywikibot/coremaster+3 -3
pywikibot/__init__.py: Remove deprecation of deprecate_argpywikibot/coremaster+1 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dalba created this task.Apr 8 2017, 3:47 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptApr 8 2017, 3:47 AM
Dalba updated the task description. (Show Details)Apr 8 2017, 3:57 AM
gerritbot subscribed.Apr 8 2017, 4:17 AM

Change 347138 had a related patch set uploaded (by Dalba):
[pywikibot/core@master] pywikibot/__init__.py: Do not use deprecate_arg

https://gerrit.wikimedia.org/r/347138

gerritbot added a project: Patch-For-Review.Apr 8 2017, 4:17 AM
Dalba added a parent task: T151145: Make Travis (and Appveyor) pass again.Apr 8 2017, 4:18 AM
Lokal_Profil subscribed.Apr 10 2017, 2:06 PM
gerritbot added a comment.Apr 14 2017, 9:10 AM

Change 348203 had a related patch set uploaded (by Dalba):
[pywikibot/core@master] pywikibot/__init__.py: Remove deprecation of deprecate_arg

https://gerrit.wikimedia.org/r/348203

Xqt triaged this task as Medium priority.Apr 14 2017, 9:30 AM
Lokal_Profil added a comment.Apr 15 2017, 7:46 AM

Is the second patch replacing the first or should they be considered two alternative solutions?

Dalba added a comment.Apr 15 2017, 9:14 AM
In T162509#3184324, @Lokal_Profil wrote:

Is the second patch replacing the first or should they be considered two alternative solutions?

Alternative solutions.

gerritbot added a comment.Apr 17 2017, 9:01 AM

Change 347138 merged by jenkins-bot:
[pywikibot/core@master] pywikibot/__init__.py: Do not use deprecate_arg

https://gerrit.wikimedia.org/r/347138

gerritbot added a comment.Apr 17 2017, 9:01 AM

Change 348203 abandoned by Xqt:
pywikibot/__init__.py: Remove deprecation of deprecate_arg

Reason:
pywikibot.deprecate_arg is deprecated, pywikibot.tools.deprecate_arg should be used instead.

https://gerrit.wikimedia.org/r/348203

Xqt closed this task as Resolved.Apr 23 2017, 1:07 PM
Xqt claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits