Page MenuHomePhabricator
Create Task
Maniphest T163434

Librarize TestingAccessWrapper
Closed, ResolvedPublic
Actions

Description

TestingAccessWrapper has been moved to wikimedia/testing-access-wrapper, core/extensions need to be updated.

Details

SubjectRepoBranchLines +/-
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/DonationInterfacemaster+69 -5
Remove TestingAccessWrapper class (now available via composer)mediawiki/coremaster+3 -14
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/LoginNotifymaster+2 -0
Add wikimedia/testing-access-wrappermediawiki/coreREL1_28+1 -0
Add wikimedia/testing-access-wrappermediawiki/coreREL1_27+1 -0
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/MobileFrontendmaster+3 -3
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/Flowmaster+1 -1
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/Wikibasemaster+2 -2
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/Echomaster+1 -0
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/Gadgetsmaster+3 -0
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/PageViewInfomaster+6 -3
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/CentralAuthmaster+5 -0
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/PageImagesmaster+2 -2
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/ConfirmEditmaster+1 -0
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/EmailAuthmaster+1 -1
Switch to librarized version of TestingAccessWrappermediawiki/coremaster+290 -483
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/TwoColConflictmaster+2 -0
Switch TestingAccessWrapper to librarized versionmediawiki/extensions/CollaborationKitmaster+12 -0
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Apr 20 2017, 11:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2017, 11:31 AM
Tgr mentioned this in rESCCe5aad53946af: Switch TestingAccessWrapper to librarized version.Apr 20 2017, 11:35 AM
Tgr mentioned this in rECKT11110f8c470e: Switch TestingAccessWrapper to librarized version.
Tgr mentioned this in rEEMAb2c89d9aca4f: Switch TestingAccessWrapper to librarized version.
Tgr added a comment.Apr 20 2017, 11:54 AM

Jenkins seems to have tied itself into a knot over the switch from \TestingAccessWrapper to \Wikimedia\TestingAccessWrapper:

  • extension tests ignore the extension's composer.json and just use core/vendor (see mw-fetch-composer-dev.sh)
  • core patches run a couple extension tests as well, which fail
  • DonationInterface tests run with 1.27 core. (The tests pass, I have no idea why.)

The first two should be solvable by splitting up the core patch. Not sure what should be done about DonationInterface though.

gerritbot subscribed.Apr 20 2017, 5:28 PM

Change 349163 merged by jenkins-bot:
[mediawiki/core@master] Switch to librarized version of TestingAccessWrapper

https://gerrit.wikimedia.org/r/349163

gerritbot added a comment.Apr 20 2017, 5:28 PM

Change 349103 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349103

gerritbot added a comment.Apr 20 2017, 5:28 PM

Change 349105 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349105

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 20 2017, 6:00 PM
Tgr mentioned this in rELGNf431bc71964b: Switch TestingAccessWrapper to librarized version.Apr 20 2017, 7:17 PM
gerritbot added a comment.Apr 20 2017, 7:28 PM

Change 349104 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349104

gerritbot added a comment.Apr 20 2017, 7:31 PM

Change 349100 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349100

gerritbot added a comment.Apr 20 2017, 7:35 PM

Change 349093 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349093

gerritbot added a comment.Apr 20 2017, 7:36 PM

Change 349099 merged by jenkins-bot:
[mediawiki/extensions/EmailAuth@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349099

gerritbot added a comment.Apr 20 2017, 7:36 PM

Change 349098 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349098

gerritbot added a comment.Apr 20 2017, 7:36 PM

Change 349165 merged by jenkins-bot:
[mediawiki/extensions/PageImages@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349165

gerritbot added a comment.Apr 20 2017, 7:37 PM

Change 349088 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349088

gerritbot added a comment.Apr 20 2017, 7:37 PM

Change 349094 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349094

gerritbot added a comment.Apr 20 2017, 7:39 PM

Change 349097 merged by jenkins-bot:
[mediawiki/extensions/PageViewInfo@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349097

gerritbot added a comment.Apr 20 2017, 7:39 PM

Change 349095 merged by jenkins-bot:
[mediawiki/extensions/Gadgets@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349095

gerritbot added a comment.Apr 21 2017, 7:41 PM

Change 349473 merged by jenkins-bot:
[mediawiki/core@REL1_27] Add wikimedia/testing-access-wrapper

https://gerrit.wikimedia.org/r/349473

gerritbot added a comment.Apr 21 2017, 7:42 PM

Change 349474 merged by jenkins-bot:
[mediawiki/core@REL1_28] Add wikimedia/testing-access-wrapper

https://gerrit.wikimedia.org/r/349474

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.28-release-notes.Apr 21 2017, 8:00 PM
Krinkle moved this task from Untriaged to In Dev on the Librarization board.Apr 30 2017, 8:25 PM
gerritbot added a comment.Apr 30 2017, 8:28 PM

Change 349101 merged by jenkins-bot:
[mediawiki/extensions/LoginNotify@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349101

hashar unsubscribed.May 1 2017, 4:58 PM
gerritbot added a comment.May 23 2017, 7:51 AM

Change 349209 merged by jenkins-bot:
[mediawiki/core@master] Remove TestingAccessWrapper class (now available via composer)

https://gerrit.wikimedia.org/r/349209

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 23 2017, 8:00 AM
Tgr closed this task as Resolved.EditedMay 23 2017, 8:50 AM
Tgr claimed this task.

All merged except DonationInterface which is related to fundraising and those extensions have their own release cadence. We can call this done.

Tgr added a comment.May 23 2017, 8:54 AM

Relevant patchsets which were not tagged with this task:

gerritbot added a comment.Jun 1 2017, 1:03 AM

Change 349092 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Switch TestingAccessWrapper to librarized version

https://gerrit.wikimedia.org/r/349092

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)); removed MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).Jun 1 2017, 2:00 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits