Page MenuHomePhabricator
Create Task
Maniphest T163566

Remove the "show changes" radio button selection
Closed, ResolvedPublic
Actions

Description

Motivation
When testing the extension, it looked like users always seem to want to see both changes, and not just theirs. Therefore the "show changes" radiobutton selection (which allowed to toggle between "both changes" and "mine") is superfluous.

Task
Remove the "show changes" radiobutton.

Details

SubjectRepoBranchLines +/-
Remove "show changes" filter optionsmediawiki/extensions/TwoColConflictmaster+0 -78
Customize query in gerrit

Related Objects

Event Timeline

Lea_WMDE created this task.Apr 21 2017, 5:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2017, 5:29 PM
Tobi_WMDE_SW moved this task from Proposed to Todo on the WMDE-TechWish board.Apr 25 2017, 3:37 PM
WMDE-Fisch claimed this task.Apr 26 2017, 4:06 PM
WMDE-Fisch moved this task from Todo to Sprint ready on the WMDE-TechWish board.
gerritbot subscribed.Apr 26 2017, 4:20 PM

Change 350438 had a related patch set uploaded (by WMDE-Fisch):
[mediawiki/extensions/TwoColConflict@master] Remove "show changes" filter options

https://gerrit.wikimedia.org/r/350438

gerritbot added a project: Patch-For-Review.Apr 26 2017, 4:20 PM
WMDE-Fisch mentioned this in rESCC9c8f19df5f42: Remove "show changes" filter options.Apr 26 2017, 4:20 PM
WMDE-Fisch moved this task from Sprint ready to Currently in sprint on the WMDE-TechWish board.Apr 26 2017, 4:20 PM
WMDE-Fisch mentioned this in rESCC4b7b9381f9c9: Remove "show changes" filter options.Apr 27 2017, 12:53 PM
WMDE-Fisch mentioned this in rESCCea06138a21b6: Remove "show changes" filter options.Apr 27 2017, 1:58 PM
Lea_WMDE mentioned this in T162806: Make TwoColConflict a beta feature on all wikis.Apr 28 2017, 3:49 PM
WMDE-Fisch mentioned this in rESCC80bbbc3a0585: Remove "show changes" filter options.May 2 2017, 8:49 AM
WMDE-Fisch mentioned this in rESCC125ebd64227b: Remove "show changes" filter options.May 2 2017, 9:17 AM
gerritbot added a comment.May 3 2017, 8:30 AM

Change 350438 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Remove "show changes" filter options

https://gerrit.wikimedia.org/r/350438

WMDE-Fisch moved this task from Currently in sprint to Done on the WMDE-TechWish board.May 3 2017, 8:49 AM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 3 2017, 9:00 AM
Addshore closed this task as Resolved.May 11 2017, 8:50 AM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Jun 6 2017, 3:01 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJun 6 2017, 3:01 PM
Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 11:59 AM
Tobi_WMDE_SW moved this task from Incoming to Edit Conflict Handling on the TCB-Team (now WMDE-TechWish) board.Oct 10 2017, 9:37 AM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL