Currently suggestedParentNodeTypes is only checked during isolateAndUnwrap, which means if you try to convert a paragraph to a heading inside a list it will unwrap (the primary use case), however we should protect against other actions that would lead to headings being inserted into lists, such as copy & paste, or naive API calls (such as SurfaceFragment#insert).
parentNodeTypes is enforced during document#fixupInsertion, which is run on every transactionBuilder and is much more robust.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Duplicate | None | T57746 Multiline list items rendering differently in ContentEditable than the resulting wikitext | |||
| Resolved | Esanders | T164016 Tables can be created inside list items, even though that is invalid wikitext | |||
| Resolved | DLynch | T164017 Enforce suggestedParentNodeTypes in fixupInsertion |
Change 361890 had a related patch set uploaded (by Jforrester; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] dm.SurfaceFragment tests: exercise fixupInsertion for mwHeadings
Change 361888 had a related patch set uploaded (by Jforrester; owner: DLynch):
[VisualEditor/VisualEditor@master] dm.Document fixupInsertion: check suggestedParents as well
Change 361888 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] dm.Document fixupInsertion: check suggestedParents as well
Change 361940 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b528a5321)
Change 361940 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b528a5321)
Change 361890 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b528a5321)