Page MenuHomePhabricator

graph's mapsnapshot protocol incorrectly validates map style parameter
Open, NormalPublic

Description

Regex bug - the style parameter in graph wrapper does not correctly validate style param.

The fix has already been done in the vega wrapper code.

It needs to be deployed to graphoid and to graph extension.

Event Timeline

Yurik created this task.Apr 28 2017, 12:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2017, 12:43 AM

Change 350784 had a related patch set uploaded (by Yurik; owner: Yurik):
[mediawiki/extensions/Graph@master] Switched to npm-stored graph-shared, fix mapsnapshot

https://gerrit.wikimedia.org/r/350784

Change 350785 had a related patch set uploaded (by Yurik; owner: Yurik):
[mediawiki/services/graphoid@master] Switched to npm-stored graph-shared, fix mapsnapshot

https://gerrit.wikimedia.org/r/350785

Change 350785 merged by jenkins-bot:
[mediawiki/services/graphoid@master] Switched to npm-stored graph-shared, fix mapsnapshot

https://gerrit.wikimedia.org/r/350785

Change 350784 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] Switched to npm-stored graph-shared, fix mapsnapshot

https://gerrit.wikimedia.org/r/350784

Mentioned in SAL (#wikimedia-operations) [2017-05-08T21:17:12Z] <mobrovac@tin> Started deploy [graphoid/deploy@a288409]: Switched to npm-stored graph-shared, fix mapsnapshot - T164046

Mentioned in SAL (#wikimedia-operations) [2017-05-08T21:17:50Z] <mobrovac@tin> Finished deploy [graphoid/deploy@a288409]: Switched to npm-stored graph-shared, fix mapsnapshot - T164046 (duration: 00m 38s)

Mentioned in SAL (#wikimedia-operations) [2017-05-08T21:18:18Z] <mobrovac@tin> Started deploy [graphoid/deploy@a288409]: Switched to npm-stored graph-shared, fix mapsnapshot - T164046

Mentioned in SAL (#wikimedia-operations) [2017-05-08T21:22:10Z] <mobrovac@tin> Finished deploy [graphoid/deploy@a288409]: Switched to npm-stored graph-shared, fix mapsnapshot - T164046 (duration: 03m 51s)

Mentioned in SAL (#wikimedia-operations) [2017-05-08T21:24:11Z] <mobrovac@tin> Started deploy [graphoid/deploy@a288409]: Switched to npm-stored graph-shared, fix mapsnapshot - T164046

Mentioned in SAL (#wikimedia-operations) [2017-05-08T21:25:51Z] <mobrovac@tin> Finished deploy [graphoid/deploy@a288409]: Switched to npm-stored graph-shared, fix mapsnapshot - T164046 (duration: 01m 39s)