Page MenuHomePhabricator

Welcome dialog in VE has scrollbar in Firefox
Closed, ResolvedPublic1 Story Points

Description

Reproducible in Firefox, but not in Vivaldi:


Just after the showing animation is finished, the dialog is still big enough to show without scrollbar, but then for some reason decreases its height just by one line.
Don't know whether this is caused by a change in VE or in OOjs UI, but this scrollbar wasn't there some time ago.

Event Timeline

Schnark created this task.Apr 28 2017, 9:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2017, 9:14 AM

Is this on a Linux device? That platform has serious font height management issues that's come up several times before…

Is this on a Linux device?

Yes

I think it's just that the combination of German and Firefox+Linux default font makes it wrap to three lines.

Change 351820 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Allow welcome dialog to be variable height

https://gerrit.wikimedia.org/r/351820

Jdforrester-WMF closed this task as Resolved.May 4 2017, 6:39 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 4 2017, 6:39 PM

Change 351820 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Allow welcome dialog to be variable height

https://gerrit.wikimedia.org/r/351820