Page MenuHomePhabricator
Create Task
Maniphest T164056

Welcome dialog in VE has scrollbar in Firefox
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Reproducible in Firefox, but not in Vivaldi:

Bildschirmfoto am 2017-04-28 um 11.08.04.png (314×500 px, 27 KB)

Just after the showing animation is finished, the dialog is still big enough to show without scrollbar, but then for some reason decreases its height just by one line.
Don't know whether this is caused by a change in VE or in OOjs UI, but this scrollbar wasn't there some time ago.

Details

SubjectRepoBranchLines +/-
Allow welcome dialog to be variable heightmediawiki/extensions/VisualEditormaster+4 -5
Customize query in gerrit

Event Timeline

Schnark created this task.Apr 28 2017, 9:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2017, 9:14 AM
Jdforrester-WMF subscribed.May 2 2017, 7:15 PM

Is this on a Linux device? That platform has serious font height management issues that's come up several times before…

Schnark added a comment.May 3 2017, 8:26 AM
In T164056#3229004, @Jdforrester-WMF wrote:

Is this on a Linux device?

Yes

Esanders subscribed.May 4 2017, 11:47 AM

I think it's just that the combination of German and Firefox+Linux default font makes it wrap to three lines.

gerritbot subscribed.May 4 2017, 12:08 PM

Change 351820 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Allow welcome dialog to be variable height

https://gerrit.wikimedia.org/r/351820

gerritbot added a project: Patch-For-Review.May 4 2017, 12:08 PM
Jdforrester-WMF closed this task as Resolved.May 4 2017, 6:39 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki; removed Patch-For-Review, Regression.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 4 2017, 6:39 PM
gerritbot added a comment.May 4 2017, 6:47 PM

Change 351820 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Allow welcome dialog to be variable height

https://gerrit.wikimedia.org/r/351820

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 4 2017, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL